+1 what Nick says. Code structure isn’t perfect but it seems good enough for now, if you can exclude jetty.
Frankly, at some point we should consider a home for Avatica outside of Calcite. Then it would make sense to let it grow beyond 2 maven modules. Julian On Apr 6, 2015, at 10:10 AM, Nick Dimiduk <[email protected]> wrote: > I agree code structure is still not perfect. I'd like to see decoupling of > the transport protocol, transport format, and both client remoting bits and > concrete implementations (CalciteRemote, JdbcRemote, &c.) Ideally we'll be > able to drop in runtime jars for {json,thrift,protobuf}/{http,http2,thrift}. > > For now, can you use exclude statements in your dependency descriptor? > > On Sun, Apr 5, 2015 at 9:16 PM, Xavier Leong <[email protected]> > wrote: > >> Hi, notice that since 652, the JdbcMeta been moved to Avatica-server, the >> problem here is that avatica-server is full application with Jetty as >> dependencies, if I'm incorporating the server code within my web service, I >> do not need Jetty. This also seem inconsistent with LocalService.java, >> which is also part of server code >> >> Can the JdbcMeta be part of local service package in avatica library? Or >> another option is to move the Main and HttServer implementation from >> avatica-server to example, and avatica-server remains as library >> implementation. >> >> Thoughts? >> >> Best regards, >> -Xavier. >> >> DISCLAIMER >> ========== >> This e-mail may contain privileged and confidential information which is >> the property of Persistent Systems Ltd. It is intended only for the use of >> the individual or entity to which it is addressed. If you are not the >> intended recipient, you are not authorized to read, retain, copy, print, >> distribute or use this message. If you have received this communication in >> error, please notify the sender and delete all copies of this message. >> Persistent Systems Ltd. does not accept any liability for virus infected >> mails. >> >>
