Sure. Will do. Also, Just now I'm walking through the new HOWTO session you wrote for new contributors. On csv-example I got one issue similar to the one they found at Apache Drill project. I don't know maybe it's just me...anyways, error is "Could not find or load main class sqlline.SqlLine" and my maven is 3.3.1 and java is 1.8.0_25. Pasting what I found below in case you guys have thoughts on that. I'm still checking.
http://mail-archives.apache.org/mod_mbox/incubator-drill-dev/201312.mbox/%[email protected]%3E <http://mail-archives.apache.org/mod_mbox/incubator-drill-dev/201312.mbox/%[email protected]%3E> Progress so far-------------------Looks like apache-rat-plugin didn't like me logging the content to log.txt under incubator-drill. Once I instructed mvn to log the output outside the folder, the build got completed without any error. Open issue---------------The sqlline.bat looks as follows:if not exist contrib\sqlline\target ( cd contrib\sqlline mvn package cd ..\.. )java -Xmx1G -Dlogback.configurationFile=.\sqlparser\src\test\resources\logback.xml -jar contrib\sqlline\target\drill-sqlline-1.0.0-m2-incubating-SNAPSHOT.jar --verbose=true The updated pom.xml has been attached. In the pom.xml I have included maven-jar-plugin to add Manifest entries for Classpath and Main-Class. I have attached the MANIFEST.MF as well for reference. As per jar spec, maven breaks the classpath at 72 and the continuation starts with a single space. I have checked that all the files specified in the classpath is available in my local repository. The problem I am facing is that java is not able to find sqlline.SqlLine class from the classpath. D:\workspace\incubator-drill>java -Xmx1G -Dlogback.configurationFile=.\sqlparser\src\test\resources\logback.xml -jar contrib\sqlline\target\drill-sqlline-1.0.0-m2-incubating-SNAPSHOT.jar --verbose=true Error: Could not find or load main class sqlline.SqlLine For now I have ignored passing the command line parameter. But that is not related to the problem at hand. This SO answer suggests the command be included in the back quotes, if the command is not executed from the directory containing the jar, but Windows doesn't support command substitution. And this SO answer suggests to downgrade the maven version to 2.3.2 and change classpath configuration so that each jar path starts in a new line. Since I am not manually adding the classpath, I am not sure how to implement this suggestion. Would you please let me know your thoughts on this? I appreciate any help on this. Regards, Ravi From: [email protected] To: [email protected] Subject: RE: [OS: Windows] Could not find or load main class sqlline.SqlLine Date: Sat, 28 Dec 2013 15:33:44 +0530 > On Apr 24, 2015, at 12:41 PM, Julian Hyde <[email protected]> wrote: > > Ah yes. Can you change those references to CalciteConnection and submit a > patch? > > On Fri, Apr 24, 2015 at 10:03 AM, Ethan Wang <[email protected]> wrote: >> Oh I know why it was not found now. >> >> We need to update >> https://github.com/julianhyde/incubator-calcite/blob/master/README.md#Example >> >> <https://github.com/julianhyde/incubator-calcite/blob/master/README.md#Example> >> (Example section.) then. >> >> This section is pretty helpful for a user trying to set up. >> >> >> >> >> >>> On Apr 24, 2015, at 11:58 AM, Ethan Wang <[email protected]> wrote: >>> >>> Thanks Julian, somehow my eclipse not able to trace declaration in this >>> project. Thanks showing me git hub search. >>> >>>> On Apr 24, 2015, at 11:52 AM, Julian Hyde <[email protected]> wrote: >>>> >>>> It's now called CalciteConnection. To find you more, you can use >>>> search: >>>> https://github.com/apache/incubator-calcite/search?utf8=%E2%9C%93&q=CalciteConnection, >>>> or find, or your IDE. >>>> >>>> On Fri, Apr 24, 2015 at 9:00 AM, Ethan Wang <[email protected]> wrote: >>>>> Hey Julian, >>>>> >>>>> That HOWTO session is pretty helpful thanks for making it and plz commit >>>>> it. >>>>> >>>>> A naive question, do you know where is OptiqConnection class defined? >>>>> >>>>> Thanks >>>>> >>>>> >>>>>> On Apr 22, 2015, at 1:55 PM, Julian Hyde <[email protected]> wrote: >>>>>> >>>>>> I just drafted a “getting started” section in the HOWTO. Is it helpful? >>>>>> Anything I’ve missed? >>>>>> >>>>>> https://github.com/julianhyde/incubator-calcite/blob/master/doc/HOWTO.md#getting-started >>>>>> >>>>>> If it looks good I’ll commit it. >>>>>> >>>>>> Julian >>>>>> >>>>> >>> >>
