I've rebased your change and committed to my master branch[1] for testing. I will go ahead and commit to apache master in about 24 hours. If you manage to create a better test case before then I will include it. But if not I will still include your fix in the release.
Julian [1] https://github.com/julianhyde/incubator-calcite/commit/53b4b09606de5fe14f49e65a6d5b4346ec930a62 On Mon, May 18, 2015 at 11:25 AM, Julian Hyde <[email protected]> wrote: > I’m not sure that your test case demonstrates the problem. I tried the > test case (join.oq) without your code change (RelOptUtil.java) and it > passed. > > On May 18, 2015, at 6:19 AM, Jesus Camachorodriguez < > [email protected]> wrote: > > > I have created a new pull request with the test case for CALCITE-688. > > > > Thanks, > > Jesús > > > > On 5/17/15, 7:12 AM, "Julian Hyde" <[email protected]> wrote: > > > >> I'm close to making the first release candidate. The issues we saw in > Hive > >> have been cleared up. > >> > >> I'm going to commit https://github.com/apache/incubator-calcite/pull/86 > >> and > >> https://github.com/apache/incubator-calcite/pull/79 (both just doc, so > >> won't impact stability). > >> > >> And I'll need to write release notes. > >> > >> Jesus, I'd like to commit > >> https://github.com/apache/incubator-calcite/pull/78 but I need a test > >> case. > >> In join.oq would be the best place. > >> > >> I'll look at https://issues.apache.org/jira/browse/CALCITE-259, > >> https://issues.apache.org/jira/browse/CALCITE-712 and commit them if > >> they're ready. > >> > >> Other pull requests https://github.com/apache/incubator-calcite/pulls > or > >> jira cases tagged "next"[1] don't look ready. Correct me if I've missed > >> something. > >> > >> Julian > >> > >> [1] > >> > https://issues.apache.org/jira/issues/?jql=project%20%3D%20CALCITE%20AND%2 > >> 0fixVersion%20%3D%20%22next%22%20 > > > >
