I have checked in a fix for https://issues.apache.org/jira/browse/CALCITE-752 and have also verified that example/csv/sqlline.bat works under Windows.
Julian On Tue, Jul 7, 2015 at 10:50 PM, George Spofford <[email protected]> wrote: > I should have checked JIRA first, sorry! > > On Tue, Jul 7, 2015 at 10:10 PM, Jinfeng Ni <[email protected]> wrote: > >> I filed Calcite-752 for the sqlline issue in example/csv module last month, >> and provide a patch for it. >> >> https://issues.apache.org/jira/browse/CALCITE-752 >> >> >> >> On Tue, Jul 7, 2015 at 8:55 PM, Julian Hyde <[email protected]> wrote: >> >> > I see that I fixed core/pom.xml in >> > https://issues.apache.org/jira/browse/CALCITE-692 but did not fix >> > example/csv/pom.xml. >> > >> > It looks like you've completed the task I started. And your "hack" to >> > force maven to ignore warnings is exactly right. >> > >> > So I was wrong, it wasn't a windows problem. I'm still going to check >> > on Windows before I commit. >> > >> > Julian >> > >> > >> > On Tue, Jul 7, 2015 at 8:17 PM, Julian Hyde <[email protected]> wrote: >> > > Probably a windows issue. >> > > >> > > Are you running the sqlline.bat in root or example/csv? >> > > >> > > Run 'mvn clean' then 'mvn install' then run sqlline.bat again. >> > > >> > > If you have cygwin, try running sqlline.sh instead. >> > > >> > > Regardless, please log a jira case. I will try to reproduce on a >> > > windows VM tomorrow. >> > > >> > > Julian >> > > >> > > >> > > On Tue, Jul 7, 2015 at 7:41 PM, George Spofford <[email protected] >> > >> > wrote: >> > >> Hi there and sorry if this is well-known to the community. I'm >> starting >> > to >> > >> try to familiarize myself with Calcite (years too late!). Downloading >> > the >> > >> 1.4 from the github mirror today and building, I follow the steps on >> > >> https://calcite.incubator.apache.org/docs/tutorial.html >> > >> >> > >> When I cd'd to the example/csv directory and run sqlline.bat, I get >> the >> > >> following: >> > >> >> > >> Error: Could not find or load main class sqlline.SqlLine >> > >> >> > >> >> > >> Turns out that sqlline is not a dependency in this POM. >> > >> >> > >> sh-4.1$ mvn dependency:tree >> > >> [INFO] Scanning for projects... >> > >> [INFO] >> > >> [INFO] Using the builder >> > >> >> > >> org.apache.maven.lifecycle.internal.builder.singlethreaded.SingleThreadedBuilder >> > >> with a thread >> > >> count of 1 >> > >> [INFO] >> > >> [INFO] >> > >> >> ------------------------------------------------------------------------ >> > >> [INFO] Building Calcite Example CSV 1.4.0-incubating-SNAPSHOT >> > >> [INFO] >> > >> >> ------------------------------------------------------------------------ >> > >> [INFO] >> > >> [INFO] --- maven-dependency-plugin:2.10:tree (default-cli) @ >> > >> calcite-example-csv --- >> > >> [INFO] >> > org.apache.calcite:calcite-example-csv:jar:1.4.0-incubating-SNAPSHOT >> > >> [INFO] +- >> > >> org.apache.calcite:calcite-core:jar:1.4.0-incubating-SNAPSHOT:compile >> > >> [INFO] | +- >> > >> >> org.apache.calcite:calcite-avatica:jar:1.4.0-incubating-SNAPSHOT:compile >> > >> [INFO] | +- commons-dbcp:commons-dbcp:jar:1.4:compile >> > >> [INFO] | | \- commons-pool:commons-pool:jar:1.5.4:compile >> > >> [INFO] | +- >> > >> com.fasterxml.jackson.core:jackson-annotations:jar:2.1.1:compile >> > >> [INFO] | +- com.google.code.findbugs:jsr305:jar:1.3.9:compile >> > >> [INFO] | +- net.hydromatic:eigenbase-properties:jar:1.1.5:compile >> > >> [INFO] | +- org.codehaus.janino:janino:jar:2.7.6:compile >> > >> [INFO] | +- org.codehaus.janino:commons-compiler:jar:2.7.6:compile >> > >> [INFO] | \- >> > >> org.pentaho:pentaho-aggdesigner-algorithm:jar:5.1.5-jhyde:compile >> > >> [INFO] | +- commons-lang:commons-lang:jar:2.4:compile >> > >> [INFO] | \- commons-logging:commons-logging:jar:1.1.3:compile >> > >> [INFO] +- >> > >> >> org.apache.calcite:calcite-linq4j:jar:1.4.0-incubating-SNAPSHOT:compile >> > >> [INFO] +- com.fasterxml.jackson.core:jackson-core:jar:2.1.1:compile >> > >> [INFO] +- >> com.fasterxml.jackson.core:jackson-databind:jar:2.1.1:compile >> > >> [INFO] +- com.google.guava:guava:jar:14.0.1:compile >> > >> [INFO] +- junit:junit:jar:4.11:test >> > >> [INFO] | \- org.hamcrest:hamcrest-core:jar:1.3:test >> > >> [INFO] +- net.sf.opencsv:opencsv:jar:2.3:compile >> > >> [INFO] \- org.apache.commons:commons-lang3:jar:3.2:compile >> > >> [INFO] >> > >> >> ------------------------------------------------------------------------ >> > >> >> > >> >> > >> To add it, I hacked the POM to NOT fail on warnings, since sqlline is >> > not >> > >> otherwise a dependency for anything in the project. >> > >> >> > >> <build> >> > >> <plugins> >> > >> <plugin> >> > >> <!-- override default version 2.8 for access to additional >> > >> config settings --> >> > >> <groupId>org.apache.maven.plugins</groupId> >> > >> <artifactId>maven-dependency-plugin</artifactId> >> > >> <version>2.10</version> >> > >> <executions> >> > >> <execution> >> > >> <id>analyze</id> >> > >> <goals> >> > >> <goal>analyze-only</goal> >> > >> </goals> >> > >> <configuration> >> > >> <failOnWarning>false</failOnWarning> >> > >> </configuration> >> > >> </execution> >> > >> </executions> >> > >> </plugin> >> > >> </plugins> >> > >> </build> >> > >> >> > >> Then, everything seems to work fine. >> > >> >> > >> My build environment for Calcite is: >> > >> >> > >> Windows 7 Pro SP1 x64, 16 GB RAM >> > >> Calcite 1.4 (commit 03111d2b680c4f4eb4886d60cab9beebd1c7bdcb) >> > >> Maven 3.2.1 >> > >> JDK 1.8.0_45 >> > >> >> > >> Thank you for any assistance! >> > >> >> > >> George Spofford >> > >>
