I don’t use Eclipse so I can’t help with Eclipse code style. Calcite’s style is 
fairly close to Google’s guidelines, so maybe you can find a formatter that 
implements the Google style. But then again, please don’t submit a patch that 
has a lot of whitespace changes…

Checkstyle doesn’t reformat code, it just tells you what you’ve done wrong. I 
find the messages fairly intuitive, but I’ll explain the ones you hit:

> /Users/pxiong/Projects/calcite/incubator-calcite/core/src/main/java/org/apache/calcite/rel/rules/SortUnionTransposeRule.java:57:
> Line matches the illegal pattern 'Trailing whitespace’.

This means that there are 1 or more spaces at the end of a line. There should 
be none.

> /Users/pxiong/Projects/calcite/incubator-calcite/core/src/main/java/org/apache/calcite/rel/rules/SortUnionTransposeRule.java:61:7:
> 'if' is not followed by whitespace.

There must be one space between ‘if’ and ‘(‘. This ensures that ‘if’ doesn’t 
look like a function call.

Julian

Reply via email to