@Willem Thanks for taking care of it. I just wonder whether the "instanceof String" check is required. I thought the introspection logic would pick the right method (i.e. setServiceClass(String)) if the argument is a String.
On Mon, Jan 19, 2009 at 3:30 AM, Willem Jiang (JIRA) <[email protected]> wrote: > > [ > https://issues.apache.org/activemq/browse/CAMEL-1254?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=48800#action_48800 > ] > > Willem Jiang commented on CAMEL-1254: > ------------------------------------- > > @ William > I changed the code to be here, and it also fixed the CXF test failures on my > box (JDK1.5.0_13) > {code} > public void setServiceClass(Object instance) { > if (instance instanceof String) { > serviceClass = (String) instance; > } else { > serviceClass = ClassHelper.getRealClass(instance).getName(); > } > } > {code} > >> camel-cxf: URI option for serviceClass does not support lookup in registry >> -------------------------------------------------------------------------- >> >> Key: CAMEL-1254 >> URL: https://issues.apache.org/activemq/browse/CAMEL-1254 >> Project: Apache Camel >> Issue Type: Improvement >> Components: camel-cxf >> Affects Versions: 1.5.0 >> Reporter: Claus Ibsen >> Assignee: William Tam >> Priority: Minor >> >> Having an endpoint such as: >> {code} >> String cxfEndpoint = >> "cxf://http://localhost:8080/part-five/webservices/incident"; >> + >> "?serviceClass=org.apache.camel.example.reportincident.ReportIncidentEndpoint" >> + "&wsdlURL=report_incident.wsdl"; >> {code} >> The serviceClass option currently only supports defining a FQN for the class. >> I think we need to support Registry lookup as well using the # notation. So >> you can do: >> {code} >> String cxfEndpoint = >> "cxf://http://localhost:8080/part-five/webservices/incident"; >> + "?serviceClass=#reportService" >> + "&wsdlURL=report_incident.wsdl"; >> {code} >> And then have it defined in Spring XML: >> {code} >> <bean id="reportService" class="..."> >> {code} >> The # notation is already supported if you use the cxf Spring XML >> configuration. We need this in the Java DSL as well. >> Sorry if it already exists. But I got a hint from a Camel end user that it >> didn't > > -- > This message is automatically generated by JIRA. > - > You can reply to this email to add a comment to the issue online. > >
