[ 
https://issues.apache.org/activemq/browse/CAMEL-1461?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=51019#action_51019
 ] 

Claus Ibsen commented on CAMEL-1461:
------------------------------------

@Marat,

The problem is that the replyTo is inherited from the very first 
{{from("activemq:queue:request")}} when you send a replyTo JMS Message to it in 
the first place - then this replyTo is propagated in the the route.
And we dont want this replyTo propgated when you send to other JMS 
destinations, such as the topic.

The changes introduces check the MEP contract. If the MEP is *not* out capable 
then it wont set a {{JMSReplyTo}} on the {{javax.jms.Message}} object when 
Camel sends it. 
This is more correct than ignoring this fact, its very common to route messages 
with Camel using JMS and send it to other JMS destinations during the routing.

Remembering to add {{jmsDisableReplyTo=true}} is a pity workaround IMHO and 
many end users will face same problem as Michael and wont find the solution 
immediately. The JMS component has too many options and its hard to know which 
options to use for what. Maybe splitting the table into commonly used, rarely 
used and advanced only would help out. 

> A request route with a topic node incurs a 20 second wait and refers to the 
> wrong MEP.
> --------------------------------------------------------------------------------------
>
>                 Key: CAMEL-1461
>                 URL: https://issues.apache.org/activemq/browse/CAMEL-1461
>             Project: Apache Camel
>          Issue Type: Bug
>          Components: camel-jms
>    Affects Versions: 1.6.0
>         Environment: ActiveMQ/Camel
>            Reporter: Michael Chen
>            Assignee: Claus Ibsen
>             Fix For: 2.0.0, 1.6.1
>
>
> If a route contains a node that publishes to a topic, the route is 
> incorrectly suspended for a default 20 seconds at the topic node.  Further, 
> JmsProducer.java checks the MEP of the original request Exchange and not the 
> endpoint of the topic.
> For example, say I have a route built like this:
> {code}
> from("activemq:queue:request").
>   to("generate_news").
>   to("activemq:topic:news").
>   to("do_something_else");
> {code}
> The original request is expecting a reply. However, after the "news" is 
> pumped into the news topic, there is a default 20 second wait 
> (requestTimeout).  This wait always results in the exception: "The OUT 
> message was not received within: 20000 millis on the exchange..." 
> After reading the JmsProducer code, I changed the route to the following:
> {code}
> from("activemq:queue:request").
>   to("generate_news").
>   to("activemq:topic:news?exchangePattern=InOnly").
>   to("do_something_else");
> {code}
> This reveals the root of the bug, which is in the first few lines of method 
> org.apache.camel.component.jms.JmsProducer.process(Exchange):
> {code}//
>     public void process(final Exchange exchange) {
>         final org.apache.camel.Message in = exchange.getIn();
>         if (exchange.getPattern().isOutCapable()) {
> {code}
> The above if statement checks the MEP of the original request's Exchange and 
> not the new endpoint of the news topic. This makes the above 
> "?exchangePattern=InOnly" configuration useless, because the original request 
> MEP is InOut.  The result is that after that 20 second time-out, the 
> temporary queue for the original request has expired, so the whole request 
> failed. Note that the next node "do_something_else" is never reached due to 
> the time-out exception.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to