[
https://issues.apache.org/activemq/browse/CAMEL-1392?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=52559#action_52559
]
Jonathan Anstey commented on CAMEL-1392:
----------------------------------------
Nice work Xueqiang. A few comments before I will commit this to trunk:
- Each time the route is edited, we get a new route id (route1, route2, route3,
etc...). The original route id should be preserved.
- We probably won't be able to support rendering closure expressions nicely
unfortunately... a closure could be arbitrary Groovy code, which makes things
very difficult. You may want to move on with the project and keep CAMEL-1769 as
a known bug for now. Of course, you are MORE than welcome to give it a bit more
thought/come up with a solution :)
- Just as an FYI we'll eventually want to move the text renderer API to
camel-core and the Groovy renderer to camel-groovy - its fine for now since
this is still experimental. Maybe when the project is closer to completion
later this summer you can do this work.
- You should start adding in some unit tests for the renderer so we can keep
track of what we know is rendering correctly.
> groovy renderer
> ---------------
>
> Key: CAMEL-1392
> URL: https://issues.apache.org/activemq/browse/CAMEL-1392
> Project: Apache Camel
> Issue Type: Sub-task
> Reporter: James Strachan
> Assignee: Xueqiang Mi
> Attachments: camel-web-20090629.patch
>
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
