[
https://issues.apache.org/activemq/browse/CAMEL-1921?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=56153#action_56153
]
Claus Ibsen commented on CAMEL-1921:
------------------------------------
Great Christian
On top of my head when browsing the patch I have the following comments
1)
The keys for the headers uses {{org.apache.camel....}}. It should use CamelCase
syntax as that is what we do in 2.x. such as {{CamelSmppXXX}}. Its
CamelComponentXXX
2)
There is a fixed encoding for ISO-8859-1. I think it should be configurable,
for example for people using it in China, Thailand and other countries with
another encoding
3)
There are a couple of TODO. Could you add details what is missing, what is the
problem etc. And is it possible to fix that?
> New SMPP component
> ------------------
>
> Key: CAMEL-1921
> URL: https://issues.apache.org/activemq/browse/CAMEL-1921
> Project: Apache Camel
> Issue Type: New Feature
> Affects Versions: 1.6.1
> Environment: All
> Reporter: Christian Mueller
> Fix For: 2.2.0
>
> Attachments: camel-smpp.patch
>
>
> Provide a component for the SMPP (short message peer to peer) protocol to
> send and receive short messages from a SMSC (short message service center).
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
