[
https://issues.apache.org/activemq/browse/CAMEL-2549?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=58264#action_58264
]
Martin Krasser commented on CAMEL-2549:
---------------------------------------
Mitko, thanks for your second patch and your good work. A few
comments/questions after my initial review
* Why do your write the results from stdout to the message body AND header?
Writing it to the body should be sufficient (preferrably as InputStream).
* What if the executable writes the results to a file. How should these be read
then, in your opinion?
* What if the executable reads from stdin. How would one pass data in this case?
* In ExecParseUtils you do a lot of low-level command line tokenizing/parsing.
Aren't there libraries available for that?
* Why do you define an ExecBinding interface + impl but do parts of
reading/writing from/to an Exchange in ExecProducer directly? This should be
the responsibility of the ExecBinding impl.
* A minor one: A timeout value should be typed as long instead of int (a hint
in the javadocs that timeout is in milliseconds would be helpful too)
* I also agree with Claus' comments regarding # notation.
What do you think?
> Camel Exec component
> --------------------
>
> Key: CAMEL-2549
> URL: https://issues.apache.org/activemq/browse/CAMEL-2549
> Project: Apache Camel
> Issue Type: New Feature
> Affects Versions: 2.3.0
> Environment: Tested on Windows XP and Linux
> Reporter: Mitko Kolev
> Assignee: Martin Krasser
> Fix For: 2.3.0
>
> Attachments: camel-exec-patch.diff, camel-exec-patch2.diff
>
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
