[ 
https://issues.apache.org/activemq/browse/CAMEL-1799?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=58463#action_58463
 ] 

Claus Ibsen commented on CAMEL-1799:
------------------------------------

Willem good start.

I would suggest to
- use an enum for the type as you then have type safe choices in the XML 
editor. And you are missing the TransactionalErrorHandler its in camel-spring :)
- handled should be default true as its should always be true for error 
handlers. That way you do not need to configure it explicit.

And add more unit tests as error handling is very complex and we should have it 
well tested.



> Spring DSL - Add error handler DSL support so we avoid having to use spring 
> bean style
> --------------------------------------------------------------------------------------
>
>                 Key: CAMEL-1799
>                 URL: https://issues.apache.org/activemq/browse/CAMEL-1799
>             Project: Apache Camel
>          Issue Type: New Feature
>          Components: camel-spring
>    Affects Versions: 2.0-M2
>            Reporter: Claus Ibsen
>            Assignee: Willem Jiang
>             Fix For: Future
>
>
> We could use an DSL for error handling in Spring DSL
> Then we can use the <redeliveryPolicy/> tag as well. And have an enum to 
> specify the type in case we want a dead letter channel instead or 
> transactional instead
> {code:xml}
> <errorHandler id="myErrorHandler" type="DeadLetterChannel">
>     <deadLetter uri="log:dead"/>
>     <redeliveryPolicy maximumRedeliveries="5" logStackTrace="true" 
> backOffMultiplier="2"/>
> </errorHandler>
> {code}
>                    

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to