[ 
https://issues.apache.org/activemq/browse/CAMEL-2752?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=60810#action_60810
 ] 

Hadrian Zbarcea commented on CAMEL-2752:
----------------------------------------

Christian,

*MessageSupport.createMessageId() should never return null, but maybe default 
to DefaultUUIDGenerator. generateUUID().
* what if SimpleUUIDGenerator had a prefix? For instance "camel-" by default.
* shouldn't the setter/getter in the DefaultCamelContext be 
set/getUuidGenerator (note the Uuid capitalization)?
* on the same getter/setter not sure if we should allow re-setting the 
uuidGenerator on the context. Not likely to happen I know, but should we leave 
that door open?

Great work, and kudos for covering all the bases with checkstyle and all.

> Pluggable UUID generator
> ------------------------
>
>                 Key: CAMEL-2752
>                 URL: https://issues.apache.org/activemq/browse/CAMEL-2752
>             Project: Apache Camel
>          Issue Type: New Feature
>          Components: camel-core
>    Affects Versions: 2.3.0
>            Reporter: Claus Ibsen
>            Assignee: Christian Mueller
>             Fix For: 2.5.0
>
>         Attachments: Camel-2752.patch
>
>
> To allow end users to use a customer ID generator.
> We should have out of the box
> - JavaUUID (default)
> - ActiveMQUUID which uses the same logic as AMQ
> - Sequence or something for testing purpose which just use a ID counter. 
> Makes it easier for testing to *spot* correlated messages in the logs etc.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to