[
https://issues.apache.org/activemq/browse/CAMEL-3065?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=61598#action_61598
]
Hadrian Zbarcea edited comment on CAMEL-3065 at 9/1/10 8:06 PM:
----------------------------------------------------------------
@Ashwin,
Thanks for the patch, it is indeed straightforward. Two comments though:
1. i think {{sendReply}} is equally confusing (in a different way) and my
preference would be {{inOut}}. Since this is what happens anyway, the exchange
will be InOut, it is imho clearer what the semantics of this option is. Or, if
you want, you can have it as a String instead of boolean and call it {{mep}}
(better then just {{pattern}} I guess, with possible values inOnly or inOut
with the former being the default).
2. You are now a committer, so please free to commit the code unless you have
doubts in which case attaching a patch or adding a link to a git branch is ok.
I doubt you had doubts in this case :).
One more thing. I am not sure if this is necessary, camel-netty being fairly
new, but if you want to just deprecate @sync, you can mark isSync() and setSync
as @deprecated and have them get/set {{inOut}} (assuming you will use that
instead of {{sendReply}}).
was (Author: hadrian):
@Ashwin,
Thanks for the patch, it is indeed straightforward. Two comments though:
1. i think {{sendReply}} is equally confusing (in a different way) and my
preference would be {{inOut}}. Since this is what happens anyway, the exchange
will be InOut, it is imho clearer what the semantics of this option is.
2. You are now a committer, so please free to commit the code unless you have
doubts in which case attaching a patch or adding a link to a git branch is ok.
I doubt you had doubts in this case :).
One more thing. I am not sure if this is necessary, camel-netty being fairly
new, but if you want to just deprecate @sync, you can mark isSync() and setSync
as @deprecated and have them get/set {{inOut}} (assuming you will use that
instead of {{sendReply}}).
> Netty - @deprecated sync option and let it use the MEP to decide if its
> InOnly or InOut
> ---------------------------------------------------------------------------------------
>
> Key: CAMEL-3065
> URL: https://issues.apache.org/activemq/browse/CAMEL-3065
> Project: Apache Camel
> Issue Type: Improvement
> Components: camel-netty
> Affects Versions: 2.4.0
> Reporter: Claus Ibsen
> Assignee: Ashwin Karpe
> Priority: Minor
> Fix For: 3.0.0
>
> Attachments: CAMEL-3065-fix.diff
>
>
> See nabble
> http://camel.465427.n5.nabble.com/netty-issue-tp2639835p2639835.html
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
