I kept it false not to introduce anything new, simple to change and document. And I think I forgot to include tests in the patch, I'll just redo it cleaned up.
Thanks! I have tests for On Nov 9, 2010, at 12:44 AM, Claus Ibsen (JIRA) wrote: > > [ > https://issues.apache.org/activemq/browse/CAMEL-3209?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=63191#action_63191 > ] > > Claus Ibsen commented on CAMEL-3209: > ------------------------------------ > > Looks nice. Adding some unit test must be done :) > > And there is one code comment which is off by one number >> // Throw exception on non 201 > > It should be non 200 :) > > I assume you have kept the option to false by default to keep backwards > compatibility. > I would prefer it was true as default as an exception will be thrown and the > error handling of Camel can kick in. > This will also make it similar to the http components. > > Any thoughts of changing it to true as default? > > >> CXF-RS - Add throwExceptionOnFailure option >> ------------------------------------------- >> >> Key: CAMEL-3209 >> URL: https://issues.apache.org/activemq/browse/CAMEL-3209 >> Project: Apache Camel >> Issue Type: New Feature >> Components: camel-cxf >> Reporter: Claus Ibsen >> Assignee: Johan Edstrom >> Fix For: 2.6.0 >> >> Attachments: >> 0001-https-issues.apache.org-activemq-browse-CAMEL-3209.patch, >> 0002-https-issues.apache.org-activemq-browse-CAMEL-3209.patch, >> Camel____CXF_jax-rs_producer_exception.patch >> >> >> See CAMEL-3184 >> Currently you will have to check the status code of the response if its != >> 200. > > -- > This message is automatically generated by JIRA. > - > You can reply to this email to add a comment to the issue online. >
