[
https://issues.apache.org/jira/browse/CAMEL-4244?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13072257#comment-13072257
]
Claus Ibsen commented on CAMEL-4244:
------------------------------------
All the model definition classes should not have any default values on the
attributes. Eg executorServiceRef = "Aggregator" is wrong. The problem is that
we would not be able to know if that value is a default value or explicit
configured by the end user. As well it causes the XML output of the routes to
be more verbose and contain not needed details. Instead compute the value when
you create the processor, so for example if executorServiceRef is null, then
you can use "Aggregator" as default value.
> Refactor ExecutorService classes into a InstanceManagerPattern
> --------------------------------------------------------------
>
> Key: CAMEL-4244
> URL: https://issues.apache.org/jira/browse/CAMEL-4244
> Project: Camel
> Issue Type: Improvement
> Affects Versions: 2.8.0
> Reporter: Christian Schneider
> Assignee: Christian Schneider
> Fix For: 2.9.0
>
> Attachments: CAMEL-4244.patch
>
>
> Currently the management of ExecutorSevices is scattered of several classes.
> I would like to refactor this to the
> http://c2.com/cgi/wiki?InstanceManagerPattern
> So there simply is one instance manager where ExecutorServices can be looked
> up and created on demand. This would replace :
> - org.apache.camel.impl.DefaultExecutorServiceStrategy
> - org.apache.camel.spi.ExecutorServiceStrategy
> - org.apache.camel.util.concurrent.ExecutorServiceHelper
> The complete configuration should be in the manager so it does not have a
> reference to CamelContext. An instance of the manager can be retrieved or set
> on the camel context.
> Currently a class that needs an executorService asks the
> ExecutorServiceHelper if there is already a suitable service. If there is
> none it creates it. This should be changed so the class that needs the
> ExecutorService just asks the ExecutorServiceManager for a suitable service
> and it will be created on the fly if none is available. So the whole
> management is concentrated in one class.
> The disadvantage is that there is no strategy anymore. So someone who wants
> to implement a new manager has to do the whole job. I think that this is not
> such a big problem though and we can reintroduce a strategy if it is really
> needed.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
