[ 
https://issues.apache.org/jira/browse/CAMEL-4255?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13072300#comment-13072300
 ] 

Babak Vahdat commented on CAMEL-4255:
-------------------------------------

Just as note, maybe in contrast to the provided patch which simply does
{code}
assertTrue(file.delete());
{code}
a better more informative fix would be:
{code}
assertTrue("deletion of " + file.getAbsolutePath() + " failed!", file.delete());
{code}

> avoid using "\n" as line seperator while doing I/O and preferably stick to 
> System.getProperty("line.separator")
> ---------------------------------------------------------------------------------------------------------------
>
>                 Key: CAMEL-4255
>                 URL: https://issues.apache.org/jira/browse/CAMEL-4255
>             Project: Camel
>          Issue Type: Improvement
>            Reporter: Babak Vahdat
>            Assignee: Claus Ibsen
>            Priority: Minor
>             Fix For: 2.9.0
>
>         Attachments: cleanup.txt
>
>
> See 
> http://camel.465427.n5.nabble.com/VOTE-Release-Apache-Camel-2-8-0-tp4610671p4616161.html
> Other than that consider the evaluation of java.io.File.delete() returned 
> boolean value while unit-testing, to make sure a file/directory get's deleted 
> when we ask for it.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to