[
https://issues.apache.org/jira/browse/CAMEL-4381?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13093471#comment-13093471
]
Claus Ibsen commented on CAMEL-4381:
------------------------------------
When you do those big refactorings then avoid changing the logic. For example
in ServiceHelper you removed the logic which checks if a service is already
started in the startService method. That logic should be put back.
Spotting this is hard when you do big refactorings. If you want to change some
logic, then do these changes in separate commits.
> Simplify ServiceSupport and introduce ServiceWithStatus interface to remove
> tangle between util and support
> -----------------------------------------------------------------------------------------------------------
>
> Key: CAMEL-4381
> URL: https://issues.apache.org/jira/browse/CAMEL-4381
> Project: Camel
> Issue Type: Improvement
> Components: camel-core
> Affects Versions: 2.8.0
> Reporter: Christian Schneider
> Assignee: Christian Schneider
> Fix For: 2.9.0
>
>
> Currently ServiceSupport and ServiceHelper form a dependency cycle.
> ServiceSupport calls ServiceHelper to start and stop services and
> ServiceSupport operate on ServiceSupport classes.
> To solve that I introduce an Interface ServiceWithSupport (open for a better
> naming). This interface extends Service and has all relevant methods from
> ServiceSupport. So ServiceHelper can operate on ServiceWithStatus and the
> tangle goes away.
> Addtionally I split up ServiceSupport into ServiceSupport which has no
> children and ChildServiceSupport which has. This is because we seem to have
> only two classes that actually use the children functionality. The rest of
> the classes that extend ServiceSupport have no children. So having them all
> extend the old ServiceSupport introduces a lot of unneeded complexity.
> The change should be fairly compatible. The only possible problem are third
> party components that use children. As we only had two such components in
> camel the chance that something breaks is fairly low.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
