[
https://issues.apache.org/jira/browse/CAMEL-4475?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13112395#comment-13112395
]
Christian Schneider commented on CAMEL-4475:
--------------------------------------------
Hi Claus,
I found that Policy beforeWrap is only used in a single test but not in any
other form in the whole camel code. Good you spotted this. I wanted to discuss
this change but forgot to mention it. So as it does not seem to be used I think
it could be removed. The good thing about removing the method is that it
improves compatibility. If I simply changed the method parameter it would be
incompatible but if I remove the method then any code that implements the
method will still work. I think we should do this change in a separate issue
though.
Also thanks for spotting the FileEndpoint change. I thought I had already
committed this as it is a bugfix for the test in windows. Will commit that
spearately.
I still use ProcessorDefinition where it can not be avoided but I think it is a
good thing to use the simplest interface that does the job. So using NamedNode
instead should be an improvement. Do you think that will cause problems with
compatibility?
> Make API self contained
> -----------------------
>
> Key: CAMEL-4475
> URL: https://issues.apache.org/jira/browse/CAMEL-4475
> Project: Camel
> Issue Type: Improvement
> Components: camel-core
> Affects Versions: 2.8.0
> Reporter: Christian Schneider
> Assignee: Christian Schneider
> Fix For: 2.9.0
>
> Attachments: camel-4475-1.patch, camel-4475-after.png,
> camel-4475-before.png
>
>
> The API, SPI packages of camel are already quite independent after the
> previous refactorings. There are three classes in model that are still needed
> at the moment.
> ProcessorDefinition, RouteDefinition and FromDefiniton
> I propose to add the necessary methods to NamedNode to be able to reference
> most of the functionality of the classes. For RouteDefinition I propose a
> special interface that adds the ErrorHandler. For the rare cases where more
> functionality is needed a instanceof and a cast can be used.
> I will attach a patch shortly that solves the issue and would be glad about
> some reviews.
> The patch can not be fully compatible but the changes are mostly in spi
> interfaces that are probably rather rarely used.
> I will also add screenshots from structure 101 that show how much the
> architecture improves after this patch.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
