[
https://issues.apache.org/jira/browse/CAMEL-4549?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13128692#comment-13128692
]
Claus Ibsen commented on CAMEL-4549:
------------------------------------
Thanks for working on such an improvement.
If you are familiar with running maven, then you may want to ensure the source
code follow our standard layout, which you can check using a maven goal named
checkstyle. You can read about building the source with checkstyle here
http://camel.apache.org/building.html
Also you have a static initializer to add BouncyCastle as a provider. I wonder
how well that works with OSGi and IBM JDKs etc. Also static initializers tend
to have problems in trouble shooting as any exceptions thrown may not be logged
etc.
You can implement org.apache.camel.Service in the DataFormat, and in the start
method, add the provider. Then have a static field with a state so you know you
only add it once. And maybe check that its not already added etc. As some other
library may have added it etc.
> Add support for PGP to camel-crypto
> -----------------------------------
>
> Key: CAMEL-4549
> URL: https://issues.apache.org/jira/browse/CAMEL-4549
> Project: Camel
> Issue Type: Improvement
> Components: camel-crypto
> Reporter: Adam
> Fix For: 2.9.0
>
> Attachments: camel-crypt-add-pgp.patch, pubring.gpg, secring.gpg
>
>
> This is an enhancement which add upon the camel-crypto component. This patch
> has the following changes:
> - Add PGPDataFormat
> - Introduce the use of bouncycastle, it was previously only a "test" resource
> Notes:
> - The camel-crypto "component" did not exist in Jira, could you please add
> it.
> - Can you please update the bouncycastle-version from 1.40 to 1.46 in the
> parent pom. I temporarily hard coded it into the pom of this project.
> - The diff doesn't appear to allow binaries, I have a sample pgp keyring in
> my project, I will upload them as separate files
> One this patch is approved, please let me know and I will go and update the
> wiki docmentation.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
