Hi Claus: I fixed the import order shortly after that commit and verified with Checkstyle: https://github.com/apache/camel/commit/81ed16620fd224e8c7a4cb894d70f2fdaace136c
Please let me know if there is still a problem. Thanks, Gregor On Sat, Jun 21, 2014 at 2:54 AM, Claus Ibsen <claus.ib...@gmail.com> wrote: > Hi > > I think these import reorderings may cause checkstyle to fail. > > Please see building with checkstyle at > http://camel.apache.org/building > > On Sat, Jun 21, 2014 at 4:57 AM, <gzurow...@apache.org> wrote: >> Repository: camel >> Updated Branches: >> refs/heads/master 68cb6a4af -> 53158443b >> >> >> [Minor] Remove unused imports to reduce warnings >> >> Signed-off-by: Gregor Zurowski <gre...@zurowski.org> >> >> Project: http://git-wip-us.apache.org/repos/asf/camel/repo >> Commit: http://git-wip-us.apache.org/repos/asf/camel/commit/53158443 >> Tree: http://git-wip-us.apache.org/repos/asf/camel/tree/53158443 >> Diff: http://git-wip-us.apache.org/repos/asf/camel/diff/53158443 >> >> Branch: refs/heads/master >> Commit: 53158443b6d29739dffc912c0e3b0fb2f7af2088 >> Parents: 68cb6a4 >> Author: Gregor Zurowski <gre...@zurowski.org> >> Authored: Fri Jun 20 22:50:33 2014 -0400 >> Committer: Gregor Zurowski <gre...@zurowski.org> >> Committed: Fri Jun 20 22:50:33 2014 -0400 >> >> ---------------------------------------------------------------------- >> .../org/apache/camel/processor/RecipientList.java | 5 ++--- >> .../cxf/jaxrs/CxfRsHeaderFilterStrategy.java | 1 - >> ...ComponentConfigurationAndDocumentationTest.java | 2 -- >> .../camel/component/mybatis/MyBatisComponent.java | 1 - >> .../http/handlers/HttpServerChannelHandler.java | 17 ++++++++--------- >> .../camel/component/restlet/RestletProducer.java | 1 - >> .../SpringLogProcessorWithProvidedLoggerTest.java | 5 ++--- >> ...ComponentConfigurationAndDocumentationTest.java | 2 -- >> .../component/websocket/WebsocketComponent.java | 2 +- >> .../maven/FileApiMethodGeneratorMojoTest.java | 1 - >> 10 files changed, 13 insertions(+), 24 deletions(-) >> ---------------------------------------------------------------------- >> >> >> http://git-wip-us.apache.org/repos/asf/camel/blob/53158443/camel-core/src/main/java/org/apache/camel/processor/RecipientList.java >> ---------------------------------------------------------------------- >> diff --git >> a/camel-core/src/main/java/org/apache/camel/processor/RecipientList.java >> b/camel-core/src/main/java/org/apache/camel/processor/RecipientList.java >> index abb635f..fcff07a 100644 >> --- a/camel-core/src/main/java/org/apache/camel/processor/RecipientList.java >> +++ b/camel-core/src/main/java/org/apache/camel/processor/RecipientList.java >> @@ -16,6 +16,8 @@ >> */ >> package org.apache.camel.processor; >> >> +import static org.apache.camel.util.ObjectHelper.notNull; >> + >> import java.util.Iterator; >> import java.util.concurrent.ExecutorService; >> >> @@ -32,15 +34,12 @@ import >> org.apache.camel.processor.aggregate.AggregationStrategy; >> import org.apache.camel.processor.aggregate.UseLatestAggregationStrategy; >> import org.apache.camel.support.ServiceSupport; >> import org.apache.camel.util.AsyncProcessorHelper; >> -import org.apache.camel.util.CamelContextHelper; >> import org.apache.camel.util.ExchangeHelper; >> import org.apache.camel.util.ObjectHelper; >> import org.apache.camel.util.ServiceHelper; >> import org.slf4j.Logger; >> import org.slf4j.LoggerFactory; >> >> -import static org.apache.camel.util.ObjectHelper.notNull; >> - >> /** >> * Implements a dynamic <a >> * href="http://camel.apache.org/recipient-list.html";>Recipient List</a> >> >> http://git-wip-us.apache.org/repos/asf/camel/blob/53158443/components/camel-cxf/src/main/java/org/apache/camel/component/cxf/jaxrs/CxfRsHeaderFilterStrategy.java >> ---------------------------------------------------------------------- >> diff --git >> a/components/camel-cxf/src/main/java/org/apache/camel/component/cxf/jaxrs/CxfRsHeaderFilterStrategy.java >> >> b/components/camel-cxf/src/main/java/org/apache/camel/component/cxf/jaxrs/CxfRsHeaderFilterStrategy.java >> index bf73a3f..75f08fc 100644 >> --- >> a/components/camel-cxf/src/main/java/org/apache/camel/component/cxf/jaxrs/CxfRsHeaderFilterStrategy.java >> +++ >> b/components/camel-cxf/src/main/java/org/apache/camel/component/cxf/jaxrs/CxfRsHeaderFilterStrategy.java >> @@ -16,7 +16,6 @@ >> */ >> package org.apache.camel.component.cxf.jaxrs; >> >> -import org.apache.camel.Exchange; >> import org.apache.camel.component.cxf.common.message.CxfConstants; >> import org.apache.camel.impl.DefaultHeaderFilterStrategy; >> >> >> http://git-wip-us.apache.org/repos/asf/camel/blob/53158443/components/camel-mail/src/test/java/org/apache/camel/component/mail/MailComponentConfigurationAndDocumentationTest.java >> ---------------------------------------------------------------------- >> diff --git >> a/components/camel-mail/src/test/java/org/apache/camel/component/mail/MailComponentConfigurationAndDocumentationTest.java >> >> b/components/camel-mail/src/test/java/org/apache/camel/component/mail/MailComponentConfigurationAndDocumentationTest.java >> index 827dece..527995a 100644 >> --- >> a/components/camel-mail/src/test/java/org/apache/camel/component/mail/MailComponentConfigurationAndDocumentationTest.java >> +++ >> b/components/camel-mail/src/test/java/org/apache/camel/component/mail/MailComponentConfigurationAndDocumentationTest.java >> @@ -23,8 +23,6 @@ import org.apache.camel.impl.DefaultCamelContext; >> import org.apache.camel.test.junit4.CamelTestSupport; >> import org.junit.Test; >> >> -import java.util.List; >> - >> public class MailComponentConfigurationAndDocumentationTest extends >> CamelTestSupport { >> >> @Override >> >> http://git-wip-us.apache.org/repos/asf/camel/blob/53158443/components/camel-mybatis/src/main/java/org/apache/camel/component/mybatis/MyBatisComponent.java >> ---------------------------------------------------------------------- >> diff --git >> a/components/camel-mybatis/src/main/java/org/apache/camel/component/mybatis/MyBatisComponent.java >> >> b/components/camel-mybatis/src/main/java/org/apache/camel/component/mybatis/MyBatisComponent.java >> index 4a8585f..4af9125 100644 >> --- >> a/components/camel-mybatis/src/main/java/org/apache/camel/component/mybatis/MyBatisComponent.java >> +++ >> b/components/camel-mybatis/src/main/java/org/apache/camel/component/mybatis/MyBatisComponent.java >> @@ -20,7 +20,6 @@ import java.io.IOException; >> import java.io.InputStream; >> import java.util.Map; >> >> -import org.apache.camel.CamelContext; >> import org.apache.camel.Endpoint; >> import org.apache.camel.impl.UriEndpointComponent; >> import org.apache.camel.util.IOHelper; >> >> http://git-wip-us.apache.org/repos/asf/camel/blob/53158443/components/camel-netty-http/src/main/java/org/apache/camel/component/netty/http/handlers/HttpServerChannelHandler.java >> ---------------------------------------------------------------------- >> diff --git >> a/components/camel-netty-http/src/main/java/org/apache/camel/component/netty/http/handlers/HttpServerChannelHandler.java >> >> b/components/camel-netty-http/src/main/java/org/apache/camel/component/netty/http/handlers/HttpServerChannelHandler.java >> index c287142..ec28328 100644 >> --- >> a/components/camel-netty-http/src/main/java/org/apache/camel/component/netty/http/handlers/HttpServerChannelHandler.java >> +++ >> b/components/camel-netty-http/src/main/java/org/apache/camel/component/netty/http/handlers/HttpServerChannelHandler.java >> @@ -16,11 +16,19 @@ >> */ >> package org.apache.camel.component.netty.http.handlers; >> >> +import static org.jboss.netty.handler.codec.http.HttpHeaders.isKeepAlive; >> +import static >> org.jboss.netty.handler.codec.http.HttpResponseStatus.BAD_REQUEST; >> +import static >> org.jboss.netty.handler.codec.http.HttpResponseStatus.METHOD_NOT_ALLOWED; >> +import static >> org.jboss.netty.handler.codec.http.HttpResponseStatus.SERVICE_UNAVAILABLE; >> +import static >> org.jboss.netty.handler.codec.http.HttpResponseStatus.UNAUTHORIZED; >> +import static org.jboss.netty.handler.codec.http.HttpVersion.HTTP_1_1; >> + >> import java.net.SocketAddress; >> import java.net.URI; >> import java.nio.channels.ClosedChannelException; >> import java.nio.charset.Charset; >> import java.util.Iterator; >> + >> import javax.security.auth.Subject; >> import javax.security.auth.login.LoginException; >> >> @@ -49,15 +57,6 @@ import org.jboss.netty.handler.codec.http.HttpResponse; >> import org.slf4j.Logger; >> import org.slf4j.LoggerFactory; >> >> -import static >> org.jboss.netty.handler.codec.http.HttpHeaders.is100ContinueExpected; >> -import static org.jboss.netty.handler.codec.http.HttpHeaders.isKeepAlive; >> -import static >> org.jboss.netty.handler.codec.http.HttpResponseStatus.BAD_REQUEST; >> -import static >> org.jboss.netty.handler.codec.http.HttpResponseStatus.CONTINUE; >> -import static >> org.jboss.netty.handler.codec.http.HttpResponseStatus.METHOD_NOT_ALLOWED; >> -import static >> org.jboss.netty.handler.codec.http.HttpResponseStatus.SERVICE_UNAVAILABLE; >> -import static >> org.jboss.netty.handler.codec.http.HttpResponseStatus.UNAUTHORIZED; >> -import static org.jboss.netty.handler.codec.http.HttpVersion.HTTP_1_1; >> - >> /** >> * Netty HTTP {@link ServerChannelHandler} that handles the incoming HTTP >> requests and routes >> * the received message in Camel. >> >> http://git-wip-us.apache.org/repos/asf/camel/blob/53158443/components/camel-restlet/src/main/java/org/apache/camel/component/restlet/RestletProducer.java >> ---------------------------------------------------------------------- >> diff --git >> a/components/camel-restlet/src/main/java/org/apache/camel/component/restlet/RestletProducer.java >> >> b/components/camel-restlet/src/main/java/org/apache/camel/component/restlet/RestletProducer.java >> index 37e1996..4b12e35 100644 >> --- >> a/components/camel-restlet/src/main/java/org/apache/camel/component/restlet/RestletProducer.java >> +++ >> b/components/camel-restlet/src/main/java/org/apache/camel/component/restlet/RestletProducer.java >> @@ -29,7 +29,6 @@ import org.restlet.Client; >> import org.restlet.Context; >> import org.restlet.Request; >> import org.restlet.Response; >> -import org.restlet.Uniform; >> import org.slf4j.Logger; >> import org.slf4j.LoggerFactory; >> >> >> http://git-wip-us.apache.org/repos/asf/camel/blob/53158443/components/camel-spring/src/test/java/org/apache/camel/spring/processor/SpringLogProcessorWithProvidedLoggerTest.java >> ---------------------------------------------------------------------- >> diff --git >> a/components/camel-spring/src/test/java/org/apache/camel/spring/processor/SpringLogProcessorWithProvidedLoggerTest.java >> >> b/components/camel-spring/src/test/java/org/apache/camel/spring/processor/SpringLogProcessorWithProvidedLoggerTest.java >> index 6b4ac33..caa620a 100644 >> --- >> a/components/camel-spring/src/test/java/org/apache/camel/spring/processor/SpringLogProcessorWithProvidedLoggerTest.java >> +++ >> b/components/camel-spring/src/test/java/org/apache/camel/spring/processor/SpringLogProcessorWithProvidedLoggerTest.java >> @@ -16,12 +16,11 @@ >> */ >> package org.apache.camel.spring.processor; >> >> +import static >> org.apache.camel.spring.processor.SpringTestHelper.createSpringCamelContext; >> + >> import org.apache.camel.CamelContext; >> -import org.apache.camel.processor.LogProcessorTest; >> import org.apache.camel.processor.LogProcessorWithProvidedLoggerTest; >> >> -import static >> org.apache.camel.spring.processor.SpringTestHelper.createSpringCamelContext; >> - >> public class SpringLogProcessorWithProvidedLoggerTest extends >> LogProcessorWithProvidedLoggerTest { >> >> protected CamelContext createCamelContext() throws Exception { >> >> http://git-wip-us.apache.org/repos/asf/camel/blob/53158443/components/camel-sql/src/test/java/org/apache/camel/component/sql/SqlComponentConfigurationAndDocumentationTest.java >> ---------------------------------------------------------------------- >> diff --git >> a/components/camel-sql/src/test/java/org/apache/camel/component/sql/SqlComponentConfigurationAndDocumentationTest.java >> >> b/components/camel-sql/src/test/java/org/apache/camel/component/sql/SqlComponentConfigurationAndDocumentationTest.java >> index f6605c6..feeafea 100644 >> --- >> a/components/camel-sql/src/test/java/org/apache/camel/component/sql/SqlComponentConfigurationAndDocumentationTest.java >> +++ >> b/components/camel-sql/src/test/java/org/apache/camel/component/sql/SqlComponentConfigurationAndDocumentationTest.java >> @@ -23,8 +23,6 @@ import org.apache.camel.impl.DefaultCamelContext; >> import org.apache.camel.test.junit4.CamelTestSupport; >> import org.junit.Test; >> >> -import javax.swing.*; >> - >> public class SqlComponentConfigurationAndDocumentationTest extends >> CamelTestSupport { >> >> @Override >> >> http://git-wip-us.apache.org/repos/asf/camel/blob/53158443/components/camel-websocket/src/main/java/org/apache/camel/component/websocket/WebsocketComponent.java >> ---------------------------------------------------------------------- >> diff --git >> a/components/camel-websocket/src/main/java/org/apache/camel/component/websocket/WebsocketComponent.java >> >> b/components/camel-websocket/src/main/java/org/apache/camel/component/websocket/WebsocketComponent.java >> index 3998172..c08078b 100644 >> --- >> a/components/camel-websocket/src/main/java/org/apache/camel/component/websocket/WebsocketComponent.java >> +++ >> b/components/camel-websocket/src/main/java/org/apache/camel/component/websocket/WebsocketComponent.java >> @@ -23,6 +23,7 @@ import java.util.EnumSet; >> import java.util.HashMap; >> import java.util.List; >> import java.util.Map; >> + >> import javax.management.MBeanServer; >> import javax.servlet.DispatcherType; >> >> @@ -55,7 +56,6 @@ import org.eclipse.jetty.servlets.CrossOriginFilter; >> import org.eclipse.jetty.util.resource.Resource; >> import org.eclipse.jetty.util.thread.QueuedThreadPool; >> import org.eclipse.jetty.util.thread.ThreadPool; >> -import org.eclipse.jetty.websocket.WebSocketFactory; >> import org.slf4j.Logger; >> import org.slf4j.LoggerFactory; >> >> >> http://git-wip-us.apache.org/repos/asf/camel/blob/53158443/tooling/maven/camel-api-component-maven-plugin/src/test/java/org/apache/camel/maven/FileApiMethodGeneratorMojoTest.java >> ---------------------------------------------------------------------- >> diff --git >> a/tooling/maven/camel-api-component-maven-plugin/src/test/java/org/apache/camel/maven/FileApiMethodGeneratorMojoTest.java >> >> b/tooling/maven/camel-api-component-maven-plugin/src/test/java/org/apache/camel/maven/FileApiMethodGeneratorMojoTest.java >> index d52de9d..86d7575 100644 >> --- >> a/tooling/maven/camel-api-component-maven-plugin/src/test/java/org/apache/camel/maven/FileApiMethodGeneratorMojoTest.java >> +++ >> b/tooling/maven/camel-api-component-maven-plugin/src/test/java/org/apache/camel/maven/FileApiMethodGeneratorMojoTest.java >> @@ -23,7 +23,6 @@ import org.apache.camel.component.test.TestProxy; >> import org.apache.maven.plugin.MojoExecutionException; >> import org.apache.maven.plugin.MojoFailureException; >> import org.junit.Test; >> -import static org.junit.Assert.assertTrue; >> >> /** >> * Tests {@link FileApiMethodGeneratorMojo} >> > > > > -- > Claus Ibsen > ----------------- > Red Hat, Inc. > Email: cib...@redhat.com > Twitter: davsclaus > Blog: http://davsclaus.com > Author of Camel in Action: http://www.manning.com/ibsen > hawtio: http://hawt.io/ > fabric8: http://fabric8.io/
