+1 (non-binding)

Tested with Maven 3.3.9 and run the blueprint tests.

regards
Grzegorz Grzybek

2015-11-19 15:06 GMT+01:00 Aki Yoshida <elak...@gmail.com>:
> +1
>
> thanks
>
>
> 2015-11-19 8:16 GMT+01:00 Claus Ibsen <claus.ib...@gmail.com>:
>> Hi
>>
>> Ah yeah I have just fixed those unit tests. It is only for a
>> representation of the uri that was affected, the logic should work as
>> before.
>>
>>
>> On Wed, Nov 18, 2015 at 6:25 PM, Aki Yoshida <elak...@gmail.com> wrote:
>>> I am still in the middle of testing but noticed one thing.
>>> Could it be that the recent change[1] in ServletComponent that removes
>>> some leading slashes from the endpoint url might have introduced some
>>> regression elsewhere?
>>>
>>> Concretely, I noticed that camel-gae's GHttpComponent is getting the
>>> endpoint url differently in 2.16.1.
>>> As a result, their unit tests are failing with the missing leading slash.
>>>
>>> org.junit.ComparisonFailure:
>>> expected:<http:/[/]somewhere.com/path?a...> but
>>> was:<http:/[]somewhere.com/path?a...>
>>>
>>> I don't know if something needs to be adjusted for this component or
>>> just for these tests.
>>>
>>> [1]
>>> https://git-wip-us.apache.org/repos/asf?p=camel.git;a=commit;h=6fb6be7f61ebe23203d48f16fe06c3e9efbc70da
>>>
>>> 2015-11-18 8:44 GMT+01:00 Gregor Zurowski <gre...@list.zurowski.org>:
>>>> Hi Everyone:
>>>>
>>>> This is a vote to release Apache Camel 2.16.1 that has over 60 fixes
>>>> and improvements.  This release also updates the Apache Commons
>>>> Collections library to version 3.2.2 that contains a patch for a
>>>> recently reported object de-serialization vulnerability [1, 2].
>>>>
>>>> Release notes: 
>>>> https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12311211&version=12333749
>>>>
>>>> Staging repository:
>>>> https://repository.apache.org/content/repositories/orgapachecamel-1043/
>>>>
>>>> Tarballs: 
>>>> https://repository.apache.org/content/repositories/orgapachecamel-1043/org/apache/camel/apache-camel/2.16.1/
>>>>
>>>> Tag: 
>>>> https://git-wip-us.apache.org/repos/asf?p=camel.git;a=tag;h=f137261500c700a2158d83e23c8e951afe0b500d
>>>>
>>>> Please test this release candidate and cast your vote.
>>>> [ ] +1 Release the binary as Apache Camel 2.16.1
>>>> [ ] -1 Veto the release (provide specific comments)
>>>>
>>>> The vote is open for at least 72 hours.
>>>>
>>>> Thanks,
>>>> Gregor
>>>>
>>>> [1] 
>>>> https://blogs.apache.org/foundation/entry/apache_commons_statement_to_widespread
>>>> [2] 
>>>> https://commons.apache.org/proper/commons-collections/release_3_2_2.html
>>
>>
>>
>> --
>> Claus Ibsen
>> -----------------
>> http://davsclaus.com @davsclaus
>> Camel in Action 2: https://www.manning.com/ibsen2

Reply via email to