Hi Claus, I believe the issue can be fixed by changing the invocation of the OsgiTypeConverter constructor on line 48 of class OsgiSpringCamelContext from:
return new OsgiTypeConverter(ctx, getInjector(), finder); to: return new OsgiTypeConverter(ctx, this, getInjector(), finder); Please let me know if we can move forward with this. Thanks, Gregor On Mon, Mar 21, 2016 at 9:47 PM, Gregor Zurowski <gre...@list.zurowski.org> wrote: > Hi Claus, > > It seems that the recent commit for CAMEL-9730 broke the > OsgiSpringCamelContext class of the camel-spring module on > branch-2.17.x: > > === > [...] > [INFO] [INFO] --- maven-compiler-plugin:3.5.1:compile > (default-compile) @ camel-spring --- > [INFO] [INFO] Changes detected - recompiling the module! > [INFO] [INFO] Compiling 60 source files to > /home/vagrant/camel/components/camel-spring/target/classes > [INFO] [INFO] ------------------------------------------------------------- > [INFO] [ERROR] COMPILATION ERROR : > [INFO] [INFO] ------------------------------------------------------------- > [INFO] [ERROR] > /home/vagrant/camel/components/camel-spring/src/main/java/org/apache/camel/osgi/OsgiSpringCamelContext.java:[48,15] > error: constructor OsgiTypeConverter in class OsgiTypeConverter cannot > be applied to given types; > [INFO] [INFO] 1 error > [...] > === > > Could you please take a look? > > Also, we would need to set up Jenkins for branch-2.17.x. Who can help > with this? > > Thanks, > Gregor > > > > On Mon, Mar 21, 2016 at 5:02 PM, Claus Ibsen <claus.ib...@gmail.com> wrote: >> On Mon, Mar 21, 2016 at 4:33 PM, Claus Ibsen <claus.ib...@gmail.com> wrote: >>> On Mon, Mar 21, 2016 at 3:26 PM, Gregor Zurowski >>> <gre...@list.zurowski.org> wrote: >>>> @Claus: Do we want to include the following commit in 2.17.0 as well? >>>> >>>> https://github.com/apache/camel/commit/d48cfeef1aa7a4760a3c43533a558de8f6a8cff9 >>>> >>> >>> Yes that is a good one to get in, you are welcome to merge it. >>> >> >> I just backported it together with another fix with CAMEL-9732 >> >> So I think the commits on the branch are the ones we need. >> >> >>> >>>> Thanks, >>>> Gregor >>>> >>>> On Mon, Mar 21, 2016 at 2:35 PM, Claus Ibsen <claus.ib...@gmail.com> wrote: >>>>> And btw this does not mean people should stop testing the current RC. >>>>> We want as much feedback as possible. >>>>> >>>>> >>>>> On Mon, Mar 21, 2016 at 2:34 PM, Claus Ibsen <claus.ib...@gmail.com> >>>>> wrote: >>>>>> Hi >>>>>> >>>>>> Okay its fixed now and pushed to master branch. >>>>>> >>>>>> I think it will cause problems for karaf users so I am voting a -1 so >>>>>> we can re-cut a RC. >>>>>> >>>>>> Gregor, can you re-cut from the master branch to pickup this fix and a >>>>>> few other minor ones? >>>>>> >>>>>> >>>>>> On Mon, Mar 21, 2016 at 1:37 PM, Claus Ibsen <claus.ib...@gmail.com> >>>>>> wrote: >>>>>>> Hi >>>>>>> >>>>>>> I found a NPE bug when using osgi blueprint testing with camel-jaxb >>>>>>> https://issues.apache.org/jira/browse/CAMEL-9730 >>>>>>> >>>>>>> And could likely also be a problem when running in real karaf. >>>>>>> >>>>>>> >>>>>>> >>>>>>> >>>>>>> >>>>>>> On Mon, Mar 21, 2016 at 9:52 AM, Gregor Zurowski >>>>>>> <gre...@list.zurowski.org> wrote: >>>>>>>> Hi Everyone: >>>>>>>> >>>>>>>> This is a vote to release Apache Camel 2.17.0, a new minor version >>>>>>>> with ~450 improvements, fixes and new features. >>>>>>>> >>>>>>>> Release notes: >>>>>>>> https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12311211&version=12333368 >>>>>>>> >>>>>>>> Staging repository: >>>>>>>> https://repository.apache.org/content/repositories/orgapachecamel-1046/ >>>>>>>> >>>>>>>> Tarballs: >>>>>>>> https://repository.apache.org/content/repositories/orgapachecamel-1046/org/apache/camel/apache-camel/2.17.0/ >>>>>>>> >>>>>>>> Tag: >>>>>>>> https://git-wip-us.apache.org/repos/asf?p=camel.git;a=tag;h=f85c4e5eb215bf74910542f04e56ab4ba6658e6c >>>>>>>> >>>>>>>> Please test this release candidate and cast your vote. >>>>>>>> [ ] +1 Release the binary as Apache Camel 2.17.0 >>>>>>>> [ ] -1 Veto the release (provide specific comments) >>>>>>>> >>>>>>>> The vote is open for at least 72 hours. >>>>>>>> >>>>>>>> Thanks, >>>>>>>> Gregor >>>>>>> >>>>>>> >>>>>>> >>>>>>> -- >>>>>>> Claus Ibsen >>>>>>> ----------------- >>>>>>> http://davsclaus.com @davsclaus >>>>>>> Camel in Action 2: https://www.manning.com/ibsen2 >>>>>> >>>>>> >>>>>> >>>>>> -- >>>>>> Claus Ibsen >>>>>> ----------------- >>>>>> http://davsclaus.com @davsclaus >>>>>> Camel in Action 2: https://www.manning.com/ibsen2 >>>>> >>>>> >>>>> >>>>> -- >>>>> Claus Ibsen >>>>> ----------------- >>>>> http://davsclaus.com @davsclaus >>>>> Camel in Action 2: https://www.manning.com/ibsen2 >>> >>> >>> >>> -- >>> Claus Ibsen >>> ----------------- >>> http://davsclaus.com @davsclaus >>> Camel in Action 2: https://www.manning.com/ibsen2 >> >> >> >> -- >> Claus Ibsen >> ----------------- >> http://davsclaus.com @davsclaus >> Camel in Action 2: https://www.manning.com/ibsen2
