ok, in that case +1, we will start using it soon (after a poc some moths ago), and the fixes in came-kafka are very welcome.
On Mon, Jun 27, 2016 at 1:59 PM Claus Ibsen <claus.ib...@gmail.com> wrote: > Hi > > No that is not a blocker. You can type in any string value you want, also > -1. > > Its only the @UriParam that has a enum that suggests it must be > "0,1,all". But there is no enforced validation on that. > > > > On Mon, Jun 27, 2016 at 1:48 PM, Andrea Cosentino > <ancosen1...@yahoo.com.invalid> wrote: > > That's right. > > > > http://kafka.apache.org/documentation.html#producerconfigs > > > > -1 is a valid value for acks. > > > > I'll commit a fix for this and maybe we'll need to cut the release again. > > > > My mistake. Sorry. > > -- > > Andrea Cosentino > > ---------------------------------- > > Apache Camel PMC Member > > Apache Karaf Committer > > Apache Servicemix Committer > > Email: ancosen1...@yahoo.com > > Twitter: @oscerd2 > > Github: oscerd > > > > > > > > On Monday, June 27, 2016 1:41 PM, Gerard Klijs <gerard.kl...@dizzit.com> > wrote: > > -1 since https://issues.apache.org/jira/browse/CAMEL-9978 will make it > > impossible to use "-1" as value for the acks, which is what we currently > > use. > > > > > > On Mon, Jun 27, 2016 at 1:21 PM Luca Burgazzoli <lburgazz...@gmail.com> > > wrote: > > > >> +1 > >> > >> --- > >> Luca Burgazzoli > >> > >> > >> On Mon, Jun 27, 2016 at 1:20 PM, Andrea Cosentino > >> <ancosen1...@yahoo.com.invalid> wrote: > >> > +1. > >> > > >> > Tested against personal projects :-) > >> > > >> > Thanks Gregor! > >> > -- > >> > Andrea Cosentino > >> > ---------------------------------- > >> > Apache Camel PMC Member > >> > Apache Karaf Committer > >> > Apache Servicemix Committer > >> > Email: ancosen1...@yahoo.com > >> > Twitter: @oscerd2 > >> > Github: oscerd > >> > > >> > > >> > > >> > On Monday, June 27, 2016 8:42 AM, Gregor Zurowski < > >> gre...@list.zurowski.org> wrote: > >> > Hi Everyone: > >> > > >> > This is a vote to release Apache Camel 2.17.2, a new patch release > >> > that includes ~58 fixes and improvements. > >> > > >> > Release notes: > >> > https://issues.apache.org/jira/secure/ReleaseNote.jspa?version=12335666&projectId=12311211 > >> > > >> > Staging repository: > >> > > https://repository.apache.org/content/repositories/orgapachecamel-1051/ > >> > > >> > Tarballs: > >> > https://repository.apache.org/content/repositories/orgapachecamel-1051/org/apache/camel/apache-camel/2.17.2/ > >> > > >> > Tag: > >> > https://git-wip-us.apache.org/repos/asf?p=camel.git;a=tag;h=789a27911fc7787675b47298cd5a7d87448f60c8 > >> > > >> > Please test this release candidate and cast your vote. > >> > [ ] +1 Release the binary as Apache Camel 2.17.2 > >> > [ ] -1 Veto the release (provide specific comments) > >> > > >> > The vote is open for at least 72 hours. > >> > > >> > Thanks, > >> > Gregor > >> > > > > -- > Claus Ibsen > ----------------- > http://davsclaus.com @davsclaus > Camel in Action 2: https://www.manning.com/ibsen2 >
