GitHub user zregvart opened a pull request:
https://github.com/apache/camel/pull/1554
CAMEL-11034 Undertow producer does not support `https`
Submitted for review, could cause serious case of lambdafobia. Thanks
:1st_place_medal:
This started as a simple addition of `XnioSSL` to
`UndertowClient::sendRequest`, but it has evolved into a partial rewrite of
`UndertowProducer`.
This I feel needed to be done as the former `UndertowProducerCallback` did
not take into account flushing/closing the request channel. Which if added to
current body of the callback resulted in
`TruncatedResponseException` due to asynchronous nature of Undertow's IO.
Also handling of errors was a bit inconsistent with the endpoint property
`throwExceptionOnFailure` which could be intentional, but I felt it was not.
So, this adds AsyncHelper template that should be used when performing
Undertow callback functionality as it ensures consistent error handling
resource management (assured close) and Camel async exchange assured end.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/zregvart/camel CAMEL-11034
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/camel/pull/1554.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1554
----
commit 13dbe6b95758ced60a4495bd7e47a6040057c424
Author: Zoran Regvart <zregv...@apache.org>
Date: 2017-03-21T13:59:47Z
CAMEL-11034 Undertow producer does not support ...
...`https`
This started as a simple addition of `XnioSSL` to
`UndertowClient::sendRequest`, but it has evolved into a partial rewrite
of `UndertowProducer`.
This I feel needed to be done as the former `UndertowProducerCallback`
did not take into account flushing/closing the request channel. Which if
added to current body of the callback resulted in
`TruncatedResponseException` due to asynchronous nature of Undertow's
IO.
Also handling of errors was a bit inconsistent with the endpoint
property `throwExceptionOnFailure` which could be intentional, but I
felt it was not.
So, this adds AsyncHelper template that should be used when performing
Undertow callback functionality as it ensures consistent error handling
resource management (assured close) and Camel async exchange assured
end.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
