Hi Just a reflection. Unfortunately on unknown reasons this is causing problems and the builds has not been working for the last 2 days. It could be related to maven versions. That Zoran is using 3.3.9 and the CI servers are 3.3.3, and up till now we supported 3.2.5 even. And I was using the oldest 3.2.5 to catch issues sooner when users are on an old version. I am bumping up to 3.3.3 myself.
We will bump up to require 3.3.3 as minimum now, but we need the build to be sorted again. However its also a lesson learned that different versions of maven can cause pain in an unexpected area such as running the checkstyle plugin. The other plugins generally work like compiler, resource, jar etc. On Sun, May 7, 2017 at 9:47 AM, Claus Ibsen <[email protected]> wrote: > Hi Zoran > > Great work. > > Do you mind adding to the building docs about that new -P update-license thing > http://camel.apache.org/building.html > > > > On Fri, May 5, 2017 at 12:37 PM, Zoran Regvart <[email protected]> wrote: >> And if we want to do some painting of the bike shed this is how >> headers should look like, I've tried to find the header style used by >> most files in order to change the least number of files: >> >> For Java/Groovy/Scala: >> https://github.com/zregvart/camel/blob/5c944919d3e9bc22e17fcec20eb91ea36f85b27c/buildingtools/src/main/resources/header-java.txt >> >> For properties files: >> https://github.com/zregvart/camel/blob/5c944919d3e9bc22e17fcec20eb91ea36f85b27c/buildingtools/src/main/resources/header-properties.txt >> >> For XML files: >> https://github.com/zregvart/camel/blob/5c944919d3e9bc22e17fcec20eb91ea36f85b27c/buildingtools/src/main/resources/header-xml.txt >> >> The Camel POM now includes the definition of mycila Maven license >> plugin that can be used to automatically format the headers with `mvn >> -Pupdate-license` >> >> zoran >> >> On Fri, May 5, 2017 at 12:32 PM, Zoran Regvart <[email protected]> wrote: >>> Hi Cameleers, >>> I'll merge (probably tomorrow), the PR[1] for CAMEL-11194[2], this >>> upgrades Checkstyle version and changes the Checkstyle rules to >>> include header checking from Java, Groovy, Scala, properties, XML and >>> XSD files. >>> >>> I've rewriten some of the headers to pass the checks and fixed a small >>> number of tests that were influenced by this. >>> >>> You can see all of this if you checkout PR#1656[1]. >>> >>> I think that the Checkstyle upgrade was long overdue, and went down >>> the rabbit hole of re-formatting the headers -- so I bundled all of >>> this in one go. >>> >>> A few pointers, for the weary ones that wish to review this: >>> >>> I first fixed a small number of Checkstyle issues: >>> https://github.com/apache/camel/pull/1656/commits/462c2b28b6c9a5f856f985c0c6d5947640530c39 >>> >>> Then I commited the upgraded Checkstyle version and rule changes: >>> https://github.com/apache/camel/pull/1656/commits/5c944919d3e9bc22e17fcec20eb91ea36f85b27c >>> >>> Changed a great number of headers (hopefully not needed for review): >>> https://github.com/apache/camel/pull/1656/commits/78f0baa629b61cdc3cd0d290814669a79ac98b2c >>> >>> Fixed tests that were affected by the change: >>> https://github.com/apache/camel/pull/1656/commits/126015ba92d75016a4fb9891d8b575a5ef7e19b2 >>> >>> zoran >>> >>> [1] https://github.com/apache/camel/pull/1656 >>> [2] https://issues.apache.org/jira/browse/CAMEL-11194 >>> -- >>> Zoran Regvart >> >> >> >> -- >> Zoran Regvart > > > > -- > Claus Ibsen > ----------------- > http://davsclaus.com @davsclaus > Camel in Action 2: https://www.manning.com/ibsen2 -- Claus Ibsen ----------------- http://davsclaus.com @davsclaus Camel in Action 2: https://www.manning.com/ibsen2
