GitHub user vrlgohel opened a pull request:

    https://github.com/apache/camel/pull/1845

    CAMEL-10126: Refactored completionSize & completionTimeout expressions

    completionTimeout & completionSize attributes and expression usages are 
confusing in xml dsl, so if we have to change the names, we need to change the 
names in camel-spring.xsd and camel-blueprint.xsd files.
    
    With the below respective changes,
    
    camel-spring.xsd
    
    <xs:element name="completionTimeoutExpr" 
type="tns:expressionSubElementDefinition" minOccurs="0"/>
    <xs:element name="completionSizeExpr" 
type="tns:expressionSubElementDefinition" minOccurs="0"/>
    
    camel-blueprint.xsd
    
        <xs:element minOccurs="0" name="completionTimeoutExpr" 
type="tns:expressionSubElementDefinition"/>
        <xs:element minOccurs="0" name="completionSizeExpr" 
type="tns:expressionSubElementDefinition"/>
    
    I tested the committed code with the above xsd changes and i am able to 
refactor code with 'completionTimeoutExpr' and 'completionSizeExpr' for the use 
in expressions. I can't commit or have access to camel-spring.xsd and 
camel-blueprint.xsd, because everytime, i build the camel-spring and 
camel-blueprint, the xsd changes.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/vrlgohel/camel-1 master

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/camel/pull/1845.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1845
    
----
commit 2e6fdd1c72e76830d7a85d6c36680b479b866272
Author: Viral Gohel <vrlgohe...@gmail.com>
Date:   2017-07-25T05:52:57Z

    [CAMEL-10126] Refactored completionSize & completionTimeout expressions

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to