GitHub user BruceKuiLiu opened a pull request:
https://github.com/apache/camel/pull/2029
Fix the problem of instanceof test always return true.
If these variables are not null, their instanceof test always return true.
They may be failed to be initialized, it would be better to do a null test
rather than an instanceof test.
http://findbugs.sourceforge.net/bugDescriptions.html#BC_VACUOUS_INSTANCEOF
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/BruceKuiLiu/camel master5
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/camel/pull/2029.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2029
----
commit 2344a95822c5768237c40e9e664f452faf499d0b
Author: Kui LIU <brucekui...@gmail.com>
Date: 2017-10-12T09:03:56Z
Fix the problem of instanceof test always return true.
This instanceof test will always return true because the classes of the
four varialbes are implemented the interface CamelContextAware.
The four variables may be failed to be initialized, it would be better to
do a null test rather than an instanceof test.
http://findbugs.sourceforge.net/bugDescriptions.html#BC_VACUOUS_INSTANCEOF
commit abab562bc40ee6d44874495e6977fbcc1623921f
Author: Kui LIU <brucekui...@gmail.com>
Date: 2017-10-12T09:12:32Z
Fix the problem of instanceof test always return true.
This instanceof test will always return true because AbstractSObjectBase is
the return type of method node.getObject().
The return value of method node.getObject() might be null, it would be
better to do a null test rather than an instanceof test.
http://findbugs.sourceforge.net/bugDescriptions.html#BC_VACUOUS_INSTANCEOF
commit f95c9e4315ee53e9b97679d9a8ce42dd11719dd7
Author: Kui LIU <brucekui...@gmail.com>
Date: 2017-10-12T09:18:58Z
Fix the problem of instanceof test always return true.
This instanceof test will always return true because the classes of the two
varialbes are implemented the interface CamelContextAware.
The two variables may be failed to be initialized, it would be better to do
a null test rather than an instanceof test.
http://findbugs.sourceforge.net/bugDescriptions.html#BC_VACUOUS_INSTANCEOF
----
---
