Thanks Pascal.

On Sun, Oct 15, 2017 at 9:47 PM, Pascal Schumacher <pascalschumac...@gmx.net
> wrote:

> Am 14.10.2017 um 16:17 schrieb Alex Dettinger:
>
>> Hi,
>>
>> Thanks for precisions. When I previously merged a PR
>> <https://github.com/apache/camel/pull/2038>. I've done:
>>
>>       git pull https://github.com/BruceKuiLiu/camel boxedParsing
>>
>> So next time, I'll also run git pull --rebase afterward.
>>
>> Apart from that, I've noticed that the merge on master ended up with a
>> commit indication that:
>>
>>       "BruceKuiLiu committed 22 hours ago".
>>
>> Whereas, the same commit cherry-picked from master to camel-2.20.x shows:
>>
>>       "BruceKuiLiu committed *with aldettinger* 22 hours ago".
>>
>> So, will I have the "committed with" indication on master too next time
>> thanks to git pull --rebase ?
>> Or is there anything else I'm missing ?
>>
>
> As far as I know "committed with" is displayed on github when the author
> and the commiter of the commit are different. Here BruceKuiLiu is the
> author and you are the committer. Git adds you as the commiter when you
> cherry-pick a commit, so I guess you cherry-picked the commit in the branch.
>
> Cheers,
> Pascal
>

Reply via email to