lburgazzoli commented on a change in pull request #55: Store integration code
in a configmap
URL: https://github.com/apache/camel-k/pull/55#discussion_r217055364
##########
File path: pkg/util/maven/maven.go
##########
@@ -107,18 +107,6 @@ func createTar(buildDir string, project
ProjectDefinition) (string, error) {
return "", err
}
- // Environment variables
Review comment:
Yes will bring them back, but I guess it is better to set them using the
deployment so they can be easily inspected so maybe they should be moved to the
IntegrationSpec ?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
