Hi

This seems like a bit weird error.

Is that heartbeatProperties something that is inherited from
spring-boot itself or where does it come from?

And would a fix be to add @ConditionalOnMissingBean on both of them?
On Wed, Oct 31, 2018 at 3:54 PM Zoran Regvart <zo...@regvart.com> wrote:
>
> Hi Cameleers,
> there are test failures in the `camel-spring-cloud-consul`[1], to me
> it seems like an issue with Spring Boot auto-configuration:
> `ConsulDiscoveryClientConfiguration::heartbeatProperties` and
> `ConsulServiceRegistryAutoConfiguration::heartbeatProperties` try to
> define the same bean, where only
> `ConsulServiceRegistryAutoConfiguration::heartbeatProperties` is
> @ConditionalOnMissingBean.
>
> Not sure what changed or how we can address this in Camel.
>
> zoran
>
> [1] 
> https://builds.apache.org/view/C/view/Apache%20Camel/job/Camel/job/spring-upgrades/2/testReport/
>
> On Tue, Oct 30, 2018 at 10:23 PM, Zoran Regvart <zo...@regvart.com> wrote:
> > Hi Cameleers,
> > looks like the build succeeded, but is hanging for some reason (could
> > be infrastructure related, not sure):
> >
> > https://builds.apache.org/view/C/view/Apache%20Camel/job/Camel/job/spring-upgrades/1/console
> >
> > zoran
> >
> > On Tue, Oct 30, 2018 at 4:19 PM, Zoran Regvart <zo...@regvart.com> wrote:
> >> Hi Cameleers,
> >> I've tinkered with Spring (5.1.2) and Spring Boot (2.1.0) upgrades,
> >> any comments welcome:
> >>
> >> https://github.com/apache/camel/pull/2584
> >>
> >> zoran
> >> --
> >> Zoran Regvart
> >
> >
> >
> > --
> > Zoran Regvart
>
>
>
> --
> Zoran Regvart



-- 
Claus Ibsen
-----------------
http://davsclaus.com @davsclaus
Camel in Action 2: https://www.manning.com/ibsen2

Reply via email to