lburgazzoli commented on a change in pull request #253: add an option to always
generate a docker image
URL: https://github.com/apache/camel-k/pull/253#discussion_r238980572
##########
File path: pkg/trait/deployment.go
##########
@@ -39,12 +41,47 @@ func newDeploymentTrait() *deploymentTrait {
}
func (d *deploymentTrait) appliesTo(e *Environment) bool {
- return e.Integration != nil && e.Integration.Status.Phase ==
v1alpha1.IntegrationPhaseDeploying
+ if e.Integration != nil && e.Integration.Status.Phase ==
v1alpha1.IntegrationPhaseDeploying {
+ return true
+ }
+
+ if d.ContainerImage == true &&
Review comment:
maybe we should add the deployment to all the profiles and differentiate
according to the platform ? I can of course create a new trait but then we have
to introduce dependencies among traits i.e. the builder need to know if the
integration image has to be created or not to determine if configmaps have to
be included or not (and maybe something else)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
