zregvart commented on issue #257: chore: add all sorts of linters and 
pre-commit hook
URL: https://github.com/apache/camel-k/pull/257#issuecomment-444482908
 
 
   > The pre commit hook config is part of the pr and the docs seems to require 
to set it up, I know I can skip them but imo it is better to put it as make 
target and eventually document how to set up hooks as part of the workfkow. 
Putting the pre commit hook config in the repo has also the drawback that may 
conflict whit others hook one may have as part of the personal workfkow.
   
   I can update the docs to make it clear that installing `pre-commit` hook is 
optional and depends on personal preference. Adding `.pre-commit-config.yaml` 
should not affect any personal workflow you have, as it is read by the 
pre-commit hook installed via [pre-commit framework](https://pre-commit.com/).
   
   Don't install `pre-commit` framework or don't run `pre-commit install` and 
your workflow should not be changed.
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to