Hi
There could be a weather-uv and weather-airpollution component in the
same JAR, eg camel-weather.
Then they can be a bit more separated, and have different options if needed.
I assume the UV and airpollution json data is diffrent than the
weather data, and therefore it can be make sense as you suggest to
create new components. But we can just keep them in the same JAR.
On Thu, Jan 10, 2019 at 2:06 PM Gandhi, Vineet <vineet.gan...@optum.com> wrote:
>
> Hi,
>
> While implementing the mentioned API’s I have a doubt in terms of design.
>
>
> 1. If we see the component it says component will provide weather details
> using some 3rd party API. Now UV Index and air pollution don’t exactly fit in
> the component description say as subcomponent of weather.
> 2. If we see the weatherConsumer example :
>
> from("weather:foo?location=Madrid,Spain&period=7
> days&appid=APIKEY").to("jms:queue:weather");
> here options signify filtering to be done for weather i.e. current location,
> zipcode, bbox.
> Now in order to support the new API’s for UV and air pollution it doesn’t
> sound right in my perspective to give them as an option parameter
> or even if we do we have to give something like “isUV=true”.
>
> URI for weather : api.openweathermap.org/data/2.5/weather?q={city
> name},{country code}
> URI for UV Index :
> http://api.openweathermap.org/data/2.5/uvi?appid={appid}&lat={lat}&lon={lon}
>
> As we see above the path is different.
> Please guide for the correct behaviour.
>
> Regards,
> Vineet
>
> From: Andrea Cosentino <ancosen1...@yahoo.com>
> Reply-To: "ancosen1...@yahoo.com" <ancosen1...@yahoo.com>
> Date: Wednesday, 9 January 2019 at 10:48 PM
> To: "dev@camel.apache.org" <dev@camel.apache.org>, "Gandhi, Vineet"
> <vineet.gan...@optum.com>, "dev@camel.apache.org" <dev@camel.apache.org>
> Subject: R: Camel weather component
>
> Contributions are always welcome :-)
> Inviato da Yahoo Mail su
> Android<https://go.onelink.me/107872968?pid=InProduct&c=Global_Internal_YGrowth_AndroidEmailSig__AndroidUsers&af_wl=ym&af_sub1=Internal&af_sub2=Global_YGrowth&af_sub3=EmailSignature>
>
> Il mer, 9 gen, 2019 alle 17:54, Gandhi, Vineet
> <vineet.gan...@optum.com> ha scritto:
> Hi,
>
> I was going through this component and checked the
> https://openweathermap.org/api.
> Some new API’s are introduced like
> https://openweathermap.org/api/uvi
>
> https://openweathermap.org/api/pollution/co
>
> I was thinking of adding those support. Also code can be made more robust I
> feel.
> Please revert back.
>
> Regards,
> Vineet
>
> This e-mail, including attachments, may include confidential and/or
> proprietary information, and may be used only by the person or entity
> to which it is addressed. If the reader of this e-mail is not the intended
> recipient or his or her authorized agent, the reader is hereby notified
> that any dissemination, distribution or copying of this e-mail is
> prohibited. If you have received this e-mail in error, please notify the
> sender by replying to this message and delete this e-mail immediately.
>
> This e-mail, including attachments, may include confidential and/or
> proprietary information, and may be used only by the person or entity
> to which it is addressed. If the reader of this e-mail is not the intended
> recipient or his or her authorized agent, the reader is hereby notified
> that any dissemination, distribution or copying of this e-mail is
> prohibited. If you have received this e-mail in error, please notify the
> sender by replying to this message and delete this e-mail immediately.
--
Claus Ibsen
-----------------
http://davsclaus.com @davsclaus
Camel in Action 2: https://www.manning.com/ibsen2
