nicolaferraro commented on a change in pull request #359: Allow to configure
the location fo the local maven repo
URL: https://github.com/apache/camel-k/pull/359#discussion_r250222184
##########
File path: deploy/platform-cr.yaml
##########
@@ -8,3 +8,4 @@ spec:
build:
camelVersion: "2.23.1"
baseImage: "fabric8/s2i-java:3.0-java8"
+ localRepository: "/tmp/artifacts/m2"
Review comment:
Better leaving it blank here and providing a default when initializing the
platform. There are platforms that will not be created by `kamel install` and
don't contain this option. Same is for the `baseImage` and also `camelVersion`,
do they have a sensible default?
When initializing the platform, we may check for empty values and pick them
from this resource file. Wdyt?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
