nicolaferraro commented on a change in pull request #583: Split builder from 
operator
URL: https://github.com/apache/camel-k/pull/583#discussion_r272276976
 
 

 ##########
 File path: pkg/builder/kaniko/publisher.go
 ##########
 @@ -111,6 +111,12 @@ func Publisher(ctx *builder.Context) error {
                args = baseArgs
        }
 
+       // The pod will be scheduled to nodes that are selected by the 
persistent volume
 
 Review comment:
   Ok, I tell you what I remember from when I fixed the issue on GKE.
   The operator was scheduled in any node and the volume was bound correctly. 
Whenever a build was started, a kaniko pod was created and it was randomly 
bound. It got bound only when the scheduler decided to assign the kaniko pod to 
the same node as the operator.
   By adding affinity, I told the cluster where I wanted to have the kaniko 
pod, and it could always bind the volume.
   
   That said... now I think we're removing the option of sharing data between 
operator and kaniko, so removing the affinity makes perfectly sense...
   
   :smile: 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to