astefanutti commented on a change in pull request #717: Allow to provide custom
settings.xml
URL: https://github.com/apache/camel-k/pull/717#discussion_r289380222
##########
File path: pkg/cmd/install.go
##########
@@ -62,8 +64,6 @@ func newCmdInstall(rootCmdOptions *RootCmdOptions)
*cobra.Command {
cmd.Flags().StringVar(&impl.registry.Address, "registry", "", "A Docker
registry that can be used to publish images")
cmd.Flags().StringVar(&impl.registry.Secret, "registry-secret", "", "A
secret used to push/pull images to the Docker registry")
cmd.Flags().BoolVar(&impl.registry.Insecure, "registry-insecure",
false, "Configure to configure registry access in insecure mode or not")
- cmd.Flags().StringSliceVar(&impl.repositories, "repository", nil, "Add
a maven repository")
- cmd.Flags().BoolVar(&impl.snapshotRepositories,
"snapshot-repositories", false, "Automatically include known snapshot
repositories")
cmd.Flags().StringVar(&impl.localRepository, "local-repository", "",
"Location of the local maven repository")
Review comment:
I wonder whether the local repository customisation should just be removed
and covered with the Maven settings?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
