jamesnetherton commented on a change in pull request #774: fix: Validate maven
artifacts
URL: https://github.com/apache/camel-k/pull/774#discussion_r297584960
##########
File path: pkg/cmd/install.go
##########
@@ -434,3 +438,12 @@ func decodeMavenSettings(mavenSettings string)
(v1alpha1.ValueSource, error) {
return v1alpha1.ValueSource{}, fmt.Errorf("illegal maven setting
definition, syntax: configmap|secret:resource-name[/settings path]")
}
+
+func containsMvnCentral(repositories []maven.Repository) bool {
+ for _, r := range repositories {
+ if r.ID == "central" {
Review comment:
Yeah I did ponder whether to make the check more complicated. Trouble is,
there's a bunch of different host name combinations that you could potentially
use for central, so checking against them isn't very reliable. Even trying to
compare IPs is maybe not 100% reliable either because of load balancers.
So I figured if someone explicitly configures central as the repo ID, then
assume it's the defacto config for Maven central.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
