lburgazzoli commented on a change in pull request #805: fix: Nil pointer on 
build failure recovery
URL: https://github.com/apache/camel-k/pull/805#discussion_r300429131
 
 

 ##########
 File path: pkg/controller/build/recovery.go
 ##########
 @@ -87,8 +87,6 @@ func (action *errorRecoveryAction) Handle(ctx 
context.Context, build *v1alpha1.B
                return nil, nil
        }
 
-       build.Status = v1alpha1.BuildStatus{}
-       build.Status.Phase = v1alpha1.BuildPhaseInitialization
 
 Review comment:
   I think resetting the phase is needed otherwise the build won'r be triggered 
again, isn't it ?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to