jamesnetherton commented on a change in pull request #805: fix: Nil pointer on
build failure recovery
URL: https://github.com/apache/camel-k/pull/805#discussion_r300453032
##########
File path: pkg/controller/build/recovery.go
##########
@@ -87,8 +87,6 @@ func (action *errorRecoveryAction) Handle(ctx
context.Context, build *v1alpha1.B
return nil, nil
}
- build.Status = v1alpha1.BuildStatus{}
- build.Status.Phase = v1alpha1.BuildPhaseInitialization
Review comment:
Yep - Sorry, that wasn't meant to be removed. I misinterpreted your earlier
comments. That's fixed now.
However, when testing on top of the latest changes, if I provide an invalid
dependency to `kamel run`, the build is actually somehow successful. That's
definitely not the behaviour when I force HEAD back to
cb988c7543ed9a17a44c53c35c50cee4a9ef19c5, the build fails and the recovery loop
kicks in as expected.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
