On Tue, Jul 9, 2019 at 9:02 AM Federico Valeri <fedeval...@gmail.com> wrote: > > Yes I use the new pkg for DefaultShutdownStrategy in camel3m4 branch of the > example and I think already have camel-main dep: > > [*INFO*] +- org.apache.camel:camel-spring:jar:3.0.0-M4:compile > > [*INFO*] | +- org.apache.camel:camel-main:jar:3.0.0-M4:compile >
Ah yeah its a sub-dep of camel-spring because we have a Spring Main class in there. > [*INFO*] | | \- org.apache.camel:camel-core-engine:jar:3.0.0-M4:compile > > On Mon, Jul 8, 2019 at 9:26 PM Claus Ibsen <claus.ib...@gmail.com> wrote: > > > And you need to add camel-main as dependency (well the maven plugin > > may bring it itself but its good practice to have it too in the pom) > > > > On Mon, Jul 8, 2019 at 9:25 PM Claus Ibsen <claus.ib...@gmail.com> wrote: > > > > > > Hi > > > > > > Ah okay that is because you need to migrate as the shutdown strategy > > > class has moved to a new package > > > > > > <bean id="shutdownStrategy" > > > class="org.apache.camel.impl.engine.DefaultShutdownStrategy"> > > > > > > You can also set the timeout in application.properties with > > > > > > camel.main.shutdown-timeout=5 > > > > > > Then you dont need the <bean> anymore > > > > > > On Mon, Jul 8, 2019 at 9:09 PM Federico Valeri <fedeval...@gmail.com> > > wrote: > > > > > > > > Hi Claus, I did several tests for #1 and I can confirm the issue. > > > > > > > > You can also try yourself using this simple example: > > > > - > > https://github.com/fvaleri/fuse-examples/tree/master/stan/jdbc-transaction > > > > (2.24.1) > > > > - > > > > > > https://github.com/fvaleri/fuse-examples/tree/camel3m4/stan/jdbc-transaction > > > > (3.0.0-M4) > > > > > > > > This is the issue for #2: > > https://issues.apache.org/jira/browse/CAMEL-13739 > > > > > > > > Thanks > > > > > > > > On Mon, Jul 8, 2019 at 8:21 PM Claus Ibsen <claus.ib...@gmail.com> > > wrote: > > > > > > > > > Hi > > > > > > > > > > Can you create a ticket for #2 > > > > > For #1 sounds like the file is not in the target/classes folder, at > > > > > the time you run the app. Can you double check. > > > > > > > > > > On Mon, Jul 8, 2019 at 7:36 PM Federico Valeri <fedeval...@gmail.com > > > > > > > > wrote: > > > > > > > > > > > > +1 > > > > > > > > > > > > A couple of minor issues I found while doing M4 tests on my support > > > > > > projects: > > > > > > > > > > > > 1. Usually, I run the command "mvn clean camel:run" to test Spring > > use > > > > > > cases, with the context definition in "META-INF/spring/camel.xml". > > > > > > This is working fine on 2.x, but I have the following Exception on > > 3.x ( > > > > > > note that it works without "clean" or doing "mvn clean compile > > > > > camel:run" ). > > > > > > > > > > > > *java.lang.reflect.InvocationTargetException* > > > > > > > > > > > > *at* sun.reflect.NativeMethodAccessorImpl.invoke0 (*Native > > Method*) > > > > > > > > > > > > *at* sun.reflect.NativeMethodAccessorImpl.invoke ( > > > > > > *NativeMethodAccessorImpl.java:62*) > > > > > > > > > > > > *at* sun.reflect.DelegatingMethodAccessorImpl.invoke ( > > > > > > *DelegatingMethodAccessorImpl.java:43*) > > > > > > > > > > > > *at* java.lang.reflect.Method.invoke (*Method.java:498*) > > > > > > > > > > > > *at* org.apache.camel.maven.RunMojo$1.run (*RunMojo.java:456*) > > > > > > > > > > > > *at* java.lang.Thread.run (*Thread.java:748*) > > > > > > > > > > > > *Caused by*: > > > > > > org.springframework.beans.factory.BeanDefinitionStoreException: > > *Could > > > > > not > > > > > > resolve bean definition resource pattern [META-INF/spring/*.xml]; > > nested > > > > > > exception is java.io.FileNotFoundException: class path resource > > > > > > [META-INF/spring/] cannot be resolved to URL because it does not > > exist* > > > > > > > > > > > > *at* > > > > > > > > > > > > > org.springframework.beans.factory.support.AbstractBeanDefinitionReader.loadBeanDefinitions > > > > > > (*AbstractBeanDefinitionReader.java:234*) > > > > > > > > > > > > *at* > > > > > > > > > > > > > org.springframework.beans.factory.support.AbstractBeanDefinitionReader.loadBeanDefinitions > > > > > > (*AbstractBeanDefinitionReader.java:195*) > > > > > > > > > > > > *at* > > > > > > > > > > > > > org.springframework.beans.factory.support.AbstractBeanDefinitionReader.loadBeanDefinitions > > > > > > (*AbstractBeanDefinitionReader.java:257*) > > > > > > > > > > > > *at* > > > > > > > > > > > > > org.springframework.context.support.AbstractXmlApplicationContext.loadBeanDefinitions > > > > > > (*AbstractXmlApplicationContext.java:128*) > > > > > > > > > > > > *at* > > > > > > > > > > > > > org.springframework.context.support.AbstractXmlApplicationContext.loadBeanDefinitions > > > > > > (*AbstractXmlApplicationContext.java:94*) > > > > > > > > > > > > *at* > > > > > > > > > > > > > org.springframework.context.support.AbstractRefreshableApplicationContext.refreshBeanFactory > > > > > > (*AbstractRefreshableApplicationContext.java:133*) > > > > > > > > > > > > *at* > > > > > > > > > > > > > org.springframework.context.support.AbstractApplicationContext.obtainFreshBeanFactory > > > > > > (*AbstractApplicationContext.java:636*) > > > > > > > > > > > > *at* > > > > > > > > org.springframework.context.support.AbstractApplicationContext.refresh ( > > > > > > *AbstractApplicationContext.java:521*) > > > > > > > > > > > > *at* > > > > > > > > > > > > > org.springframework.context.support.ClassPathXmlApplicationContext.<init> ( > > > > > > *ClassPathXmlApplicationContext.java:144*) > > > > > > > > > > > > *at* > > > > > > > > > > > > > org.springframework.context.support.ClassPathXmlApplicationContext.<init> ( > > > > > > *ClassPathXmlApplicationContext.java:95*) > > > > > > > > > > > > *at* > > org.apache.camel.spring.Main.createDefaultApplicationContext ( > > > > > > *Main.java:247*) > > > > > > > > > > > > *at* org.apache.camel.spring.Main.doStart (*Main.java:163*) > > > > > > > > > > > > *at* org.apache.camel.support.service.ServiceSupport.start ( > > > > > > *ServiceSupport.java:97*) > > > > > > > > > > > > *at* org.apache.camel.main.MainSupport.run > > (*MainSupport.java:196*) > > > > > > > > > > > > *at* org.apache.camel.main.MainSupport.run > > (*MainSupport.java:593*) > > > > > > > > > > > > *at* org.apache.camel.spring.Main.main (*Main.java:84*) > > > > > > > > > > > > *at* sun.reflect.NativeMethodAccessorImpl.invoke0 (*Native > > Method*) > > > > > > > > > > > > *at* sun.reflect.NativeMethodAccessorImpl.invoke ( > > > > > > *NativeMethodAccessorImpl.java:62*) > > > > > > > > > > > > *at* sun.reflect.DelegatingMethodAccessorImpl.invoke ( > > > > > > *DelegatingMethodAccessorImpl.java:43*) > > > > > > > > > > > > *at* java.lang.reflect.Method.invoke (*Method.java:498*) > > > > > > > > > > > > *at* org.apache.camel.maven.RunMojo$1.run (*RunMojo.java:456*) > > > > > > > > > > > > *at* java.lang.Thread.run (*Thread.java:748*) > > > > > > > > > > > > > > > > > > 2. Using camel-test without overriding "createJndiContext" gives > > the > > > > > > following warning: > > > > > > > > > > > > > > > > > > 2019-07-08 16:09:37,953 [ main] WARN > > l.test.junit4.CamelTestSupport - The > > > > > > method createJndiContext() in camel-test is deprecated. You can > > bind > > > > > beans > > > > > > directly from Camel Registry instead > > > > > > > > > > > > > > > > > > On Mon, Jul 8, 2019 at 2:34 PM Zoran Regvart <zo...@regvart.com> > > wrote: > > > > > > > > > > > > > +1 (binding) > > > > > > > > > > > > > > Thanks Gregor! > > > > > > > > > > > > > > zoran > > > > > > > > > > > > > > On Sun, Jul 7, 2019 at 11:17 AM Gregor Zurowski > > > > > > > <gre...@list.zurowski.org> wrote: > > > > > > > > > > > > > > > > Hi Everyone: > > > > > > > > > > > > > > > > This is a vote to release Apache Camel 3.0.0-M4 (Milestone 4), > > the > > > > > > > > fourth milestone towards a new 3.0.0 major release with > > another 105 > > > > > > > > improvements and fixes. > > > > > > > > > > > > > > > > Release notes: > > > > > > > > > > > > > > https://issues.apache.org/jira/secure/ReleaseNote.jspa?version=12345567&projectId=12311211 > > > > > > > > > > > > > > > > Staging repository: > > > > > > > > > > > > > > > https://repository.apache.org/content/repositories/orgapachecamel-1143/ > > > > > > > > > > > > > > > > Tarballs: > > > > > > > > > > > > > > https://repository.apache.org/content/repositories/orgapachecamel-1143/org/apache/camel/apache-camel/3.0.0-M4/ > > > > > > > > > > > > > > > > Tag: > > > > > > > > > > > > > > https://gitbox.apache.org/repos/asf?p=camel.git;a=tag;h=refs/tags/camel-3.0.0-M4 > > > > > > > > > > > > > > > > Please test this release candidate and cast your vote. > > > > > > > > [ ] +1 Release the binary as Apache Camel 3.0.0-M4 > > > > > > > > [ ] -1 Veto the release (provide specific comments) > > > > > > > > > > > > > > > > The vote is open for at least 72 hours. > > > > > > > > > > > > > > > > Thanks, > > > > > > > > Gregor > > > > > > > > > > > > > > > > > > > > > > > > > > > > -- > > > > > > > Zoran Regvart > > > > > > > > > > > > > > > > > > > > > > > > > > > -- > > > > > Claus Ibsen > > > > > ----------------- > > > > > http://davsclaus.com @davsclaus > > > > > Camel in Action 2: https://www.manning.com/ibsen2 > > > > > > > > > > > > > > > > > -- > > > Claus Ibsen > > > ----------------- > > > http://davsclaus.com @davsclaus > > > Camel in Action 2: https://www.manning.com/ibsen2 > > > > > > > > -- > > Claus Ibsen > > ----------------- > > http://davsclaus.com @davsclaus > > Camel in Action 2: https://www.manning.com/ibsen2 > > -- Claus Ibsen ----------------- http://davsclaus.com @davsclaus Camel in Action 2: https://www.manning.com/ibsen2
