ppalaga commented on issue #115: Fix #112 Make camel-quarkus-bom usable as a parent for user applications URL: https://github.com/apache/camel-quarkus/pull/115#issuecomment-519555134 > > I believe examples should have tests. First, end users need to learn how to write those tests. And second, those tests should be run by the CI because otherwise there is no certainty that we will not accidentally break them at some point. > > It is good to have tests for examples but I would build examples i.e. once a day otherwise the build will take a very long time If we have no duplicates between itests and examples there will be no change in the execution time. Daily jobs break the feedback and responsibility loop. If some breaking change happens, the author of the change cannot be notified automatically (and forced to deliver a fix) because it is generally not clear which change was the breaking one. > > I do not mind taking another one (which?) but having two close to identical apps, one under examples and one under itests does not sound right. > > Generally, I agree with your point that the itests may test aspects that have no didactic value for the app developers but as long as a given itest does not go too deep, it can well live under examples. > > The problem is that when I run itest I have to remember that for some extensions I have also to build all the examples because my memory certainly fail and I won't remember what examples are also test. If this is really a substantial issue, here is my compromise proposal: Let's postpone the discussion about examples by moving it to a separate issue. In the meantime, before we agree on how we are going to maintain the examples, lets do the following: one of the itests (is servlet a good choice?) will have `camel-quarkus-bom` as its parent. The rest of the itests will inherit from `camel-quarkus-build-parent`. WDYT?
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
