ppalaga commented on a change in pull request #119: chore: replace custom
properties binding implementation with PropertyBindingSupport from camel support
URL: https://github.com/apache/camel-quarkus/pull/119#discussion_r312166206
##########
File path:
extensions/core/runtime/src/main/java/org/apache/camel/quarkus/core/runtime/support/FastCamelRuntime.java
##########
@@ -77,21 +79,17 @@ public void stop() throws Exception {
doStop();
}
+ @SuppressWarnings("unchecked")
public void doInit() {
try {
this.context = createContext();
- // Configure the camel context using properties in the form:
- //
- // camel.context.${name} = ${value}
- //
- RuntimeSupport.bindProperties(properties, context,
PFX_CAMEL_CONTEXT);
+ if (properties != null) {
+ PropertyBindingSupport.bindProperties(context, context, new
HashMap<String, Object>((Map) properties), PFX_CAMEL_CONTEXT);
Review comment:
Is there any good reason to allocate a new `HashMap` ? Simply `(Map) props`
would compile too.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
