ppalaga commented on a change in pull request #144: chore(extension): add extension for camel-http-common URL: https://github.com/apache/camel-quarkus/pull/144#discussion_r315186783
########## File path: extensions/http-common/runtime/pom.xml ########## @@ -0,0 +1,56 @@ +<?xml version="1.0" encoding="UTF-8"?> +<project xmlns="http://maven.apache.org/POM/4.0.0"; xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"; xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd";> + <modelVersion>4.0.0</modelVersion> + <parent> + <groupId>org.apache.camel.quarkus</groupId> + <artifactId>camel-quarkus-xml-common-parent</artifactId> + <version>0.1.1-SNAPSHOT</version> + <relativePath>../pom.xml</relativePath> + </parent> + + <artifactId>camel-quarkus-http-common</artifactId> + <name>Camel Quarkus :: HTTP :: Common :: Runtime</name> + + <dependencies> + <dependency> + <groupId>org.apache.camel.quarkus</groupId> + <artifactId>camel-quarkus-core</artifactId> + </dependency> + + <!-- camel --> + <dependency> + <groupId>org.apache.camel</groupId> + <artifactId>camel-http-common</artifactId> + </dependency> + + <!-- required for http-common type converters--> + <dependency> + <groupId> org.jboss.spec.javax.servlet</groupId> + <artifactId>jboss-servlet-api_4.0_spec</artifactId> + <version>1.0.0.Final</version> Review comment: `jboss-servlet-api_4.0_spec` is managed in `io.quarkus:quarkus-bom`. There is no need to have the explicit version here. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
