asifdxtreme commented on a change in pull request #922: fix: Add option to
disable Kaniko cache warming
URL: https://github.com/apache/camel-k/pull/922#discussion_r320864286
##########
File path: pkg/cmd/install.go
##########
@@ -235,6 +237,12 @@ func (o *installCmdOptions) install(_ *cobra.Command, _
[]string) error {
platform.Spec.Build.HTTPProxySecret = o.httpProxySecret
}
+ if o.cache {
+ platform.Spec.Build.Cache = true
Review comment:
thanks for the review, I have updated it as per your suggestions, I was
trying to be defensive if someone passes non boolean values.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
