WillemJiang commented on issue #138: #137 Add the error log when setting 
component property failed 
URL: https://github.com/apache/camel-k-runtime/pull/138#issuecomment-531442837
 
 
   > thinking a little bit more about this we may throw something like
   > 
   > ```
   > new PropertyBindingException(this.component, name, "")
   > ```
   > 
   > as the Missing*Exception have some special meaning so they are not 
propagated
   
   @lburgazzoli  I checked the code of 
[PropertyBindingException](http://docs.groovy-lang.org/latest/html/api/groovy/lang/MissingPropertyException.html)
 code, the default getMessage implementation (which has the location text) is 
much better than the String message that I can feed in. So I prefer to use new 
PropertyBindingException(this.component, name) one.
   
   What do you think about it?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Reply via email to