ppalaga commented on a change in pull request #222: chore: rename
CamelRegistryBuildItem to a more meaningful CamelBeanBuildItem
URL: https://github.com/apache/camel-quarkus/pull/222#discussion_r330952088
##########
File path:
extensions/core/deployment/src/main/java/org/apache/camel/quarkus/core/deployment/CamelBeanBuildItem.java
##########
@@ -20,18 +20,22 @@
import io.quarkus.builder.item.MultiBuildItem;
-public final class CamelRegistryBuildItem extends MultiBuildItem {
+/**
+ * A MultiBuildItem holding beans to add to CamelRegistry during static
initialization phase.
+ * Can be produced only by methods that do not depend on CamelRuntime (because
otherwise there is a circular dependency).
+ */
Review comment:
The text is perfect, but having MultiBuildItem CamelRegistry and
CamelRuntime as links (or at least FQ names) would be nice.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
