ppalaga commented on a change in pull request #235: #234 Added log when
starting or stoping ActiveMQ Broker failed
URL: https://github.com/apache/camel-quarkus/pull/235#discussion_r331910246
##########
File path:
integration-tests/paho/src/test/java/org/apache/camel/quarkus/component/paho/it/ActiveMQTestResource.java
##########
@@ -38,7 +42,7 @@
broker.setDataDirectory("target");
broker.start();
} catch (Exception e) {
-
+ LOGGER.error("Starting the ActiveMQ broker with exception.", e);
Review comment:
Does it make any sense to continue with the execution of the tests if this
fails? I wonder if throwing a RuntimeException would not be better, like they
do e.g. here in Quarkus?
https://github.com/quarkusio/quarkus/blob/master/integration-tests/artemis-core/src/test/java/io/quarkus/it/artemis/ArtemisTestResource.java#L23
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
