Thanks Nicola for uploading the source artifacts in dev svn, checked the hashes and signature. Sorry I need to change my vote to -1 (non-binding), here are some issues I found in the source artifacts : - pkg/client/fastmapper.go doesn't have ASF header - Unwanted binary in source atrifacts :
root1@root1-HP-EliteBook-840-G2:~/apache/camel/camel-k-1.0.0-M2/cmd$ ll total 20 drwxr-xr-x 4 root1 root1 4096 Oct 5 15:21 ./ drwxr-xr-x 13 root1 root1 4096 Oct 5 15:21 ../ drwxr-xr-x 2 root1 root1 4096 Oct 5 15:21 kamel/ lrwxrwxrwx 1 root1 root1 70 Oct 5 15:21 manager -> /home/nferraro/gopaths/camel-k/src/github.com/apache/camel-k/cmd/kamel drwxr-xr-x 3 root1 root1 4096 Oct 5 15:21 util/ There is a binary called manager added in the cmd directory which has a reference to your local env, we should generally not include any binary in source artifacts. Regards Asif ---------------------------------------------------- ServiceComb PMC Member, Release Manager Apache IPMC Member On 2019/10/07 09:40:10, Nicola Ferraro <[email protected]> wrote: > Thanks Mohammad for spotting it, I've now added sources to the staging repo. > > Keys used for signing are in the git repo: > https://github.com/apache/camel-k/blob/ee1b8d34961df9553abc7e364e965f00dbbe2bb0/KEYS#L1661-L1715 > > Nicola > > On Mon, Oct 7, 2019 at 11:24 AM Mohammad Asif Siddiqui < > [email protected]> wrote: > > > +1 (non-binding) > > > > Suggestions : > > - I cannot find link to KEYS in the voting mail which is used to sign the > > release artifacts. > > - Source Artifacts of camel-k 1.0.0-M2 is missing in dev svn [Major > > Issue] > > > > Regards > > Asif > > ---------------------------------------------------- > > ServiceComb PMC Member, Release Manager > > Apache IPMC Member > > > > > > On 2019/10/05 10:24:10, Nicola Ferraro <[email protected]> wrote: > > > Hello all: > > > > > > This is a combined vote to release Apache Camel K 1.0.0-M2 and Apache > > Camel > > > K Runtime 1.0.4. > > > > > > Release notes: > > > https://github.com/apache/camel-k/issues/944#issuecomment-538636280 > > > > > > Runtime staging repository: > > > https://repository.apache.org/content/repositories/orgapachecamel-1156 > > > Runtime Tag: > > > > > https://gitbox.apache.org/repos/asf?p=camel-k-runtime.git;a=shortlog;h=refs/tags/camel-k-runtime-parent-1.0.4 > > > > > > Camel K staging repository: > > > https://dist.apache.org/repos/dist/dev/camel/camel-k/1.0.0-M2/ > > > Camel K Tag: > > > > > https://gitbox.apache.org/repos/asf?p=camel-k.git;a=shortlog;h=refs/tags/1.0.0-M2 > > > > > > Staging container image repository: > > https://hub.docker.com/r/camelk/camel-k > > > /tags > > > > > > It's possible to install all staging artifacts with a single command: > > > kamel install --operator-image=camelk/camel-k:1.0.0-M2 > > --maven-repository= > > > https://repository.apache.org/content/repositories/orgapachecamel-1156 > > > > > > Please test this release candidate and cast your vote. > > > > > > [ ] +1 Release the binary as Apache Camel K 1.0.0-M2 and Apache Camel K > > Runtime > > > 1.0.4 > > > [ ] -1 Veto the release (provide specific comments) > > > > > > The vote is open for at least 72 hours. > > > > > > Thanks, > > > Nicola Ferraro > > > > > >
