It looks infra allows it due to lgtm new integration https://issues.apache.org/jira/browse/INFRA-17226?focusedCommentId=16864457&page=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#comment-16864457
On Wed, Dec 18, 2019 at 9:38 AM Luca Burgazzoli <lburgazz...@gmail.com> wrote: > On Wed, Dec 18, 2019 at 9:25 AM Andrea Cosentino <anco...@gmail.com> > wrote: > > > Do they require access to the github repo? In that case I do believe > Infra > > won't allow us to use it. > > > > > Was actually thinking about the same thing, here what they do require: > https://lgtm.com/help/lgtm/github-apps-integration > > > > Il giorno mer 18 dic 2019 alle ore 09:22 Omar Al-Safi <o...@oalsafi.com> > > ha > > scritto: > > > > > That honestly I don't know about. We can give a try for one PR and see > > how > > > long it takes. If it takes some time, we just switch it off and rely on > > the > > > report it generates daily. We can also configure the type of code > > analysis > > > which can only limit to what we see that could help. > > > > > > On Wed, Dec 18, 2019, 09:15 Claus Ibsen <claus.ib...@gmail.com> wrote: > > > > > > > On Tue, Dec 17, 2019 at 4:17 PM Omar Al-Safi <oals...@apache.org> > > wrote: > > > > > > > > > > Hello folks, > > > > > > > > > > Recently, I stumbled across this code analysis tool > > https://lgtm.com/ > > > > and > > > > > is free for open source integration. It looks pretty good based on > > the > > > > > analysis results it gave for camel ( > > > > > https://lgtm.com/projects/g/apache/camel/) (sure some of them it > can > > > be > > > > > neglected). However, I was wondering, does it make sense to enable > it > > > on > > > > > PRs? For me personally, it could help to some extent to catch > > potential > > > > > bugs that hard to spot by the human eye. > > > > > > > > > > > > > For PRs then can it be limited to only the code from the PR? > > > > The Camel code base is still massive and I dont want to have some > slow > > > > process for PRs > > > > > > > > Instead of the tool just runs a general report once a week/month etc > > > > then we can take a look at it from time to time. > > > > > > > > > > > > > Regards, > > > > > Omar > > > > > > > > > > > > > > > > -- > > > > Claus Ibsen > > > > ----------------- > > > > http://davsclaus.com @davsclaus > > > > Camel in Action 2: https://www.manning.com/ibsen2 > > > > > > > > > >
