I’ve opened 4 PRs associated with subtasks of CAMEL-14698 <https://issues.apache.org/jira/browse/CAMEL-14698>. There’s some explanation in the subtask comments.
Do not try to test the camel-website PR until all the other PRs are merged. In each PR branch I’ve squashed my work into a single commit. If you want to see smaller changes, look at these branches in https://github.com/djencks/camel.git : issue-14698-rearrange-adocs (for master) camel-3.0.x-issue-14698 camel-2.x-issue-14698 The last two are, I think, just fixing some xref targets. To build using the PR branches, check out https://github.com/djencks/camel-website.git branch issue-14698-rearrange-adocs. Thanks David Jencks > On Mar 16, 2020, at 11:48 PM, Andrea Cosentino <anco...@gmail.com> wrote: > > Hello, > > I think it would be good to open the PRs so at least someone can review. > > Il mar 17 mar 2020, 06:27 David Jencks <david.a.jen...@gmail.com > <mailto:david.a.jen...@gmail.com>> ha > scritto: > >> I’m hesitant to make any more changes before what I have now is accepted >> and applied, and the longer we wait the more difficult it will be to rebase >> on the changes occurring in master. >> >> What is needed to move this forward? >> >> This is going to need at least 4 PRs to merge, and the one for >> camel-website can’t be tested until the other 3 are applied. >> >> Thanks >> David Jencks >> >>> On Mar 15, 2020, at 8:02 PM, David Jencks <david.a.jen...@gmail.com> >> wrote: >>> >>> Hi Zoran, >>> >>>> On Mar 15, 2020, at 6:28 AM, Zoran Regvart <zo...@regvart.com >>>> <mailto:zo...@regvart.com> <mailto: >> zo...@regvart.com <mailto:zo...@regvart.com>>> wrote: >>>> >>>> Hi David, >>>> >>>> On Sat, Mar 14, 2020 at 6:51 AM David Jencks <david.a.jen...@gmail.com >>>> <mailto:david.a.jen...@gmail.com> >> <mailto:david.a.jen...@gmail.com <mailto:david.a.jen...@gmail.com>>> wrote: >>>>> FWIW there are a few errors from other components building the site: >>>>> >>>>> asciidoctor: WARNING: contributor-guide.adoc: line 123: invalid style >> for listing block: code >>>>> asciidoctor: WARNING: native-mode.adoc: line 11: invalid style for >> listing block: code >>>>> asciidoctor: WARNING: native-mode.adoc: line 20: invalid style for >> listing block: code >>>>> asciidoctor: WARNING: skipping reference to missing attribute: >> camel-version >>>>> asciidoctor: WARNING: skipping reference to missing attribute: >> server-name >>>>> asciidoctor: WARNING: skipping reference to missing attribute: >> database-name >>>>> asciidoctor: WARNING: skipping reference to missing attribute: >> table-name >>>>> asciidoctor: WARNING: skipping reference to missing attribute: >> server-name >>>>> asciidoctor: WARNING: skipping reference to missing attribute: >> database-name >>>>> asciidoctor: WARNING: skipping reference to missing attribute: >> table-name >>>>> asciidoctor: WARNING: skipping reference to missing attribute: >> server-name >>>>> asciidoctor: WARNING: skipping reference to missing attribute: >> database-name >>>>> asciidoctor: WARNING: skipping reference to missing attribute: >> table-name >>>>> asciidoctor: WARNING: skipping reference to missing attribute: >> server-name >>>>> asciidoctor: WARNING: skipping reference to missing attribute: >> database-name >>>>> asciidoctor: WARNING: skipping reference to missing attribute: >> table-name >>>>> >>>>> The first three are in camel-quarkus. I haven’t found the others. >>>> >>>> I see server-name, database-name, table-name appearing in the Debezium >>>> component docs. Perhaps it would be a good task for Outreachy >>>> applicants to find and fix those (CAMEL-13923). We could work on >>>> adding a check either to the build - to scan the output and fail on >>>> these warnings; or in the Maven tooling to check for these issues. >>>> That way we would fail quickly and correct these. >>> >>> It’s going to be easy to make the maven build break on Antora errors >> and/or warnings after https://gitlab.com/antora/antora/-/issues/145 >> <https://gitlab.com/antora/antora/-/issues/145> < >> https://gitlab.com/antora/antora/-/issues/145> is finished and probably >> not worth it before then (I implemented most of one solution for this: I >> hope it gets into Antora 3). >>> >>> I ran the build against my logging antora version and got this more >> precise information: >>> >>> version: latest component: camel-quarkus file: >> modules/ROOT/pages/contributor-guide.adoc path contributor-guide.adoc >> lineno: 123 message: invalid style for listing block: code >>> version: latest component: camel-quarkus file: >> modules/ROOT/pages/native-mode.adoc path native-mode.adoc lineno: 11 >> message: invalid style for listing block: code >>> version: latest component: camel-quarkus file: >> modules/ROOT/pages/native-mode.adoc path native-mode.adoc lineno: 20 >> message: invalid style for listing block: code >>> version: 3.0.x component: components file: undefined path >> modules/ROOT/pages/azure-blob-component.adoc lineno: undefined message: >> skipping reference to missing attribute: camel-version >>> version: 3.0.x component: components file: undefined path >> modules/ROOT/pages/debezium-mongodb-component.adoc lineno: undefined >> message: skipping reference to missing attribute: server-name >>> version: 3.0.x component: components file: undefined path >> modules/ROOT/pages/debezium-mongodb-component.adoc lineno: undefined >> message: skipping reference to missing attribute: database-name >>> version: 3.0.x component: components file: undefined path >> modules/ROOT/pages/debezium-mongodb-component.adoc lineno: undefined >> message: skipping reference to missing attribute: table-name >>> version: 3.0.x component: components file: undefined path >> modules/ROOT/pages/debezium-mysql-component.adoc lineno: undefined message: >> skipping reference to missing attribute: server-name >>> version: 3.0.x component: components file: undefined path >> modules/ROOT/pages/debezium-mysql-component.adoc lineno: undefined message: >> skipping reference to missing attribute: database-name >>> version: 3.0.x component: components file: undefined path >> modules/ROOT/pages/debezium-mysql-component.adoc lineno: undefined message: >> skipping reference to missing attribute: table-name >>> version: 3.0.x component: components file: undefined path >> modules/ROOT/pages/debezium-postgres-component.adoc lineno: undefined >> message: skipping reference to missing attribute: server-name >>> version: 3.0.x component: components file: undefined path >> modules/ROOT/pages/debezium-postgres-component.adoc lineno: undefined >> message: skipping reference to missing attribute: database-name >>> version: 3.0.x component: components file: undefined path >> modules/ROOT/pages/debezium-postgres-component.adoc lineno: undefined >> message: skipping reference to missing attribute: table-name >>> version: 3.0.x component: components file: undefined path >> modules/ROOT/pages/debezium-sqlserver-component.adoc lineno: undefined >> message: skipping reference to missing attribute: server-name >>> version: 3.0.x component: components file: undefined path >> modules/ROOT/pages/debezium-sqlserver-component.adoc lineno: undefined >> message: skipping reference to missing attribute: database-name >>> version: 3.0.x component: components file: undefined path >> modules/ROOT/pages/debezium-sqlserver-component.adoc lineno: undefined >> message: skipping reference to missing attribute: table-name >>> >>> Thanks >>> David Jencks
